move region-adding loop to template

Author: j2kun

mlir/lib/Target/IRDLToCpp/IRDLToCpp.cpp

@@ -141,14 +141,6 @@ static void fillDict(irdl::detail::dictionary &dict, const OpStrings &strings) {
   dict["OP_RESULT_INITIALIZER_LIST"] =
       resultCount ? joinNameList(strings.opResultNames) : "{\"\"}";
   dict["OP_REGION_COUNT"] = std::to_string(regionCount);
-  dict["OP_ADD_REGIONS"] = regionCount
-                               ? std::string(llvm::formatv(
-                                     R"(for (unsigned i = 0; i != {0}; ++i) {{
-    (void)odsState.addRegion();
-  }
-)",
-                                     regionCount))
-                               : "";
 }
 
 /// Fills a dictionary with values from DialectStrings

mlir/lib/Target/IRDLToCpp/Templates/PerOperationDef.txt

@@ -21,7 +21,9 @@ void __OP_CPP_NAME__::build(::mlir::OpBuilder &odsBuilder,
   odsState.addOperands(operands);
   odsState.addAttributes(attributes);
   odsState.addTypes(resultTypes);
-  __OP_ADD_REGIONS__
+  for (unsigned i = 0; i != __OP_REGION_COUNT__; ++i) {
+    (void)odsState.addRegion();
+  }
 }
 
 __OP_CPP_NAME__