Cleanup

Author: mleleszi

libc/src/stdio/baremetal/printf.cpp

@@ -54,7 +54,7 @@ LLVM_LIBC_FUNCTION(int, printf, (const char *__restrict format, ...)) {
     return -1;
   }
 
-  if (retval.value >= cpp::numeric_limits<int>::max()) {
+  if (retval.value > cpp::numeric_limits<int>::max()) {
     libc_errno = EOVERFLOW;
     return -1;
   }

libc/src/stdio/baremetal/vprintf.cpp

@@ -22,7 +22,7 @@ namespace LIBC_NAMESPACE_DECL {
 namespace {
 
 LIBC_INLINE int stdout_write_hook(cpp::string_view new_str, void *) {
-  write_to_stdout(new_str); 
+  write_to_stdout(new_str);
   return printf_core::WRITE_OK;
 }
 
@@ -53,7 +53,7 @@ LLVM_LIBC_FUNCTION(int, vprintf,
 
   }
 
-  if (retval.value >= cpp::numeric_limits<int>::max()) {
+  if (retval.value > cpp::numeric_limits<int>::max()) {
     libc_errno = EOVERFLOW;
     return -1;
   }

libc/src/stdio/printf_core/core_structs.h

@@ -31,7 +31,7 @@ struct PrintfResult {
 
   constexpr bool has_error() { return error != 0; }
 
-  // constexpr operator size_t() { return value; }
+  constexpr operator size_t() { return value; }
 };
 
 // These length modifiers match the length modifiers in the format string, which

libc/src/stdio/printf_core/printf_main.h

@@ -30,10 +30,9 @@ PrintfResult printf_main(Writer<write_mode> *writer, const char *__restrict str,
        !cur_section.raw_string.empty();
        cur_section = parser.get_next_section()) {
     if (cur_section.has_conv)
-      result = convert(writer, cur_section); // look at usages
+      result = convert(writer, cur_section);
     else
-      result = writer->write(cur_section.raw_string); // look at usages
-
+      result = writer->write(cur_section.raw_string);
     if (result < 0)
       return {0, -result};
   }