Skip to content

Commit 246d5d3

Browse files
author
joaosaffran
committed
addressing comments
1 parent 6cef567 commit 246d5d3

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

llvm/test/ObjectYAML/DXContainer/RootSignature-Flags.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Parts:
1717
NumRootParameters: 0
1818
RootParametersOffset: 24
1919
NumStaticSamplers: 0
20-
StaticSamplersOffset: 12
20+
StaticSamplersOffset: 60
2121
Parameters: []
2222
AllowInputAssemblerInputLayout: true
2323
DenyGeometryShaderRootAccess: true
@@ -29,7 +29,7 @@ Parts:
2929
# CHECK-NEXT: NumRootParameters: 0
3030
# CHECK-NEXT: RootParametersOffset: 24
3131
# CHECK-NEXT: NumStaticSamplers: 0
32-
# CHECK-NEXT: StaticSamplersOffset: 12
32+
# CHECK-NEXT: StaticSamplersOffset: 60
3333
# CHECK-NEXT: Parameters: []
3434
# CHECK-NEXT: AllowInputAssemblerInputLayout: true
3535
# CHECK-NEXT: DenyGeometryShaderRootAccess: true

llvm/test/ObjectYAML/DXContainer/RootSignature-MultipleParameters.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ Parts:
1717
NumRootParameters: 2
1818
RootParametersOffset: 24
1919
NumStaticSamplers: 0
20-
StaticSamplersOffset: 12
20+
StaticSamplersOffset: 60
2121
Parameters:
2222
- ParameterType: 1 # Constants32Bit
2323
ShaderVisibility: 2 # Hull
@@ -41,7 +41,7 @@ Parts:
4141
# CHECK-NEXT: NumRootParameters: 2
4242
# CHECK-NEXT: RootParametersOffset: 24
4343
# CHECK-NEXT: NumStaticSamplers: 0
44-
# CHECK-NEXT: StaticSamplersOffset: 12
44+
# CHECK-NEXT: StaticSamplersOffset: 60
4545
# CHECK-NEXT: Parameters:
4646
# CHECK-NEXT: - ParameterType: 1
4747
# CHECK-NEXT: ShaderVisibility: 2

llvm/unittests/Object/DXContainerTest.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -823,7 +823,7 @@ TEST(DXCFile, MalformedSignature) {
823823
}
824824
}
825825

826-
TEST(RootSignature, MalformedData) {
826+
TEST(RootSignature, RootParameters) {
827827
{
828828
// Root Parameters offset has changed to 36, additional padding was added,
829829
// as well as fixing the parameter offset.

0 commit comments

Comments
 (0)