resolve review feedback

Author: mingmingl-llvm

llvm/lib/Transforms/Instrumentation/IndirectCallPromotion.cpp

@@ -138,8 +138,7 @@ static cl::list<std::string> ICPIgnoredBaseTypes(
         "A list of mangled vtable names. Classes specified by the vtables "
         "and their derived ones will not be vtable-ICP'ed. Useful when the "
         "profiled types and actual types in the optimized binary could be "
-        "different due to profiling "
-        "limitations."));
+        "different due to profiling limitations."));
 
 namespace {
 

llvm/test/Transforms/PGOProfile/icp_vtable_cmp.ll

@@ -1,8 +1,11 @@
 ; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --version 5
 
+; Tests that ICP compares vtables by checking IR.
 ; RUN: opt < %s -passes='pgo-icall-prom' -pass-remarks=pgo-icall-prom -enable-vtable-profile-use -icp-max-num-vtable-last-candidate=2 -S 2>&1 | FileCheck %s --check-prefixes=VTABLE-COMMON,VTABLE-CMP
+; Require exactly one vtable candidate for each function candidate. Tests that ICP compares function by checking IR.
 ; RUN: opt < %s -passes='pgo-icall-prom' -pass-remarks=pgo-icall-prom -enable-vtable-profile-use -icp-max-num-vtable-last-candidate=1 -S 2>&1 | FileCheck %s --check-prefixes=VTABLE-COMMON,FUNC-CMP
-; RUN: opt < %s -passes='pgo-icall-prom' -pass-remarks=pgo-icall-prom -enable-vtable-profile-use -icp-max-num-vtable-last-candidate=1 -icp-ignored-base-types='Base1' -S 2>&1 | FileCheck %s --check-prefixes=VTABLE-COMMON,FUNC-CMP
+; On top of line 4, ignore 'Base1' and its derived types for vtable-based comparison. Tests that ICP compares functions.
+; RUN: opt < %s -passes='pgo-icall-prom' -pass-remarks=pgo-icall-prom -enable-vtable-profile-use -icp-max-num-vtable-last-candidate=2 -icp-ignored-base-types='Base1' -S 2>&1 | FileCheck %s --check-prefixes=VTABLE-COMMON,FUNC-CMP
 
 target datalayout = "e-m:e-p270:32:32-p271:32:32-p272:64:64-i64:64-f80:128-n8:16:32:64-S128"
 target triple = "x86_64-unknown-linux-gnu"