Skip to content

Commit 259e086

Browse files
Add nitpicks from second read-over
1 parent 2a9ef1c commit 259e086

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

mlir/docs/Rationale/SideEffectsAndSpeculation.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ When adding a new op, ask:
8080
1. Does it read from or write to the heap or stack? It should probably implement
8181
`MemoryEffectsOpInterface`.
8282
1. Are these side effects ordered? The op should probably set the stage of
83-
side effects to make analysis more accurate.
84-
1. Do these side effects act on every single value of resource? It probably
83+
side effects to make analyses more accurate.
84+
1. Do these side effects act on every single value of a resource? It probably
8585
should set the FullEffect on effect.
8686
1. Does it have side effects that must be preserved, like a volatile store or a
8787
syscall? It should probably implement `MemoryEffectsOpInterface` and model

0 commit comments

Comments
 (0)