Address code review comments

Author: AmrDeveloper

clang/include/clang/CIR/Dialect/IR/CIRAttrs.td

@@ -811,8 +811,10 @@ def CIR_TypeInfoAttr : CIR_Attr<"TypeInfo", "typeinfo", [TypedAttrInterface]> {
     ```
   }];
 
-  let parameters = (ins AttributeSelfTypeParameter<"">:$type,
-                        CIR_IntOrGlobalViewArrayAttr:$data);
+  let parameters = (ins
+    AttributeSelfTypeParameter<"">:$type,
+    CIR_IntOrGlobalViewArrayAttr:$data
+  );
 
   let builders = [
     AttrBuilderWithInferredContext<(ins "mlir::Type":$type,

clang/lib/CIR/Dialect/IR/CIRDialect.cpp

@@ -2745,9 +2745,9 @@ LogicalResult cir::AtomicCmpXchg::verify() {
 
 LogicalResult cir::TypeInfoAttr::verify(
     ::llvm::function_ref<::mlir::InFlightDiagnostic()> emitError,
-    ::mlir::Type type, ::mlir::ArrayAttr typeinfoData) {
+    ::mlir::Type type, ::mlir::ArrayAttr typeInfoData) {
 
-  if (cir::ConstRecordAttr::verify(emitError, type, typeinfoData).failed())
+  if (cir::ConstRecordAttr::verify(emitError, type, typeInfoData).failed())
     return failure();
 
   return success();

clang/lib/CIR/Lowering/DirectToLLVM/LowerToLLVM.cpp

@@ -523,12 +523,12 @@ mlir::Value CIRAttrToValue::visitCirAttr(cir::GlobalViewAttr globalAttr) {
 }
 
 // TypeInfoAttr visitor.
-mlir::Value CIRAttrToValue::visitCirAttr(cir::TypeInfoAttr typeinfoAttr) {
-  mlir::Type llvmTy = converter->convertType(typeinfoAttr.getType());
+mlir::Value CIRAttrToValue::visitCirAttr(cir::TypeInfoAttr typeInfoAttr) {
+  mlir::Type llvmTy = converter->convertType(typeInfoAttr.getType());
   mlir::Location loc = parentOp->getLoc();
   mlir::Value result = mlir::LLVM::UndefOp::create(rewriter, loc, llvmTy);
 
-  for (auto [idx, elt] : llvm::enumerate(typeinfoAttr.getData())) {
+  for (auto [idx, elt] : llvm::enumerate(typeInfoAttr.getData())) {
     mlir::Value init = visit(elt);
     result =
         mlir::LLVM::InsertValueOp::create(rewriter, loc, result, init, idx);