Skip to content

Commit 262e39a

Browse files
committed
address some CR items
1 parent 8d80041 commit 262e39a

File tree

2 files changed

+3
-2
lines changed

2 files changed

+3
-2
lines changed

clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -718,6 +718,7 @@ wrapDeviceImages(ArrayRef<std::unique_ptr<MemoryBuffer>> Buffers,
718718
return std::move(Err);
719719
break;
720720
case OFK_SYCL: {
721+
// TODO: fill these options once the Driver supports them.
721722
offloading::SYCLWrappingOptions WrappingOptions;
722723
if (Error Err =
723724
offloading::wrapSYCLBinaries(M, BuffersToWrap, WrappingOptions))

llvm/include/llvm/Frontend/Offloading/OffloadWrapper.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,10 @@ LLVM_ABI llvm::Error wrapHIPBinary(llvm::Module &M, llvm::ArrayRef<char> Images,
5656
bool EmitSurfacesAndTextures = true);
5757

5858
struct SYCLWrappingOptions {
59-
// target/compiler specific options what are suggested to use to "compile"
59+
// Target/compiler specific options that are suggested to use to "compile"
6060
// program at runtime.
6161
std::string CompileOptions;
62-
// Target/Compiler specific options that are suggested to use to "link"
62+
// Target/compiler specific options that are suggested to use to "link"
6363
// program at runtime.
6464
std::string LinkOptions;
6565
};

0 commit comments

Comments
 (0)