const-qualify values and remove unused member

Author: brenfwd

clang-tools-extra/clang-tidy/google/FloatTypesCheck.cpp

@@ -28,7 +28,7 @@ AST_MATCHER(FloatingLiteral, isFLValidAndNotInMacro) {
 
 AST_MATCHER(TypeLoc, isLongDoubleType) {
   TypeLoc TL = Node;
-  if (auto QualLoc = Node.getAs<QualifiedTypeLoc>())
+  if (const auto QualLoc = Node.getAs<QualifiedTypeLoc>())
     TL = QualLoc.getUnqualifiedLoc();
 
   const auto BuiltinLoc = TL.getAs<BuiltinTypeLoc>();
@@ -39,7 +39,7 @@ AST_MATCHER(TypeLoc, isLongDoubleType) {
 }
 
 AST_MATCHER(FloatingLiteral, isLongDoubleLiteral) {
-  if (auto *BT = dyn_cast<BuiltinType>(Node.getType().getTypePtr()))
+  if (const auto *BT = dyn_cast<BuiltinType>(Node.getType().getTypePtr()))
     return BT->getKind() == BuiltinType::LongDouble;
   return false;
 }
@@ -57,7 +57,6 @@ void RuntimeFloatCheck::registerMatchers(MatchFinder *Finder) {
       floatLiteral(isFLValidAndNotInMacro(), isLongDoubleLiteral())
           .bind("longDoubleFloatLiteral"),
       this);
-  IdentTable = std::make_unique<IdentifierTable>(getLangOpts());
 }
 
 void RuntimeFloatCheck::check(const MatchFinder::MatchResult &Result) {

clang-tools-extra/clang-tidy/google/FloatTypesCheck.h

@@ -1,4 +1,3 @@
-
 //===----------------------------------------------------------------------===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
@@ -12,11 +11,7 @@
 
 #include "../ClangTidyCheck.h"
 
-namespace clang {
-
-class IdentifierTable;
-
-namespace tidy::google::runtime {
+namespace clang::tidy::google::runtime {
 
 /// Finds usages of `long double` and suggests replacing them with other
 /// floating-point types.
@@ -32,13 +27,8 @@ class RuntimeFloatCheck : public ClangTidyCheck {
   bool isLanguageVersionSupported(const LangOptions &LangOpts) const override {
     return LangOpts.CPlusPlus && !LangOpts.ObjC;
   }
-
-private:
-  std::unique_ptr<IdentifierTable> IdentTable;
 };
 
-} // namespace tidy::google::runtime
-
-} // namespace clang
+} // namespace clang::tidy::google::runtime
 
 #endif // LLVM_CLANG_TOOLS_EXTRA_CLANG_TIDY_GOOGLE_FLOATTYPESCHECK_H