Skip to content

Commit 267e852

Browse files
author
Vasileios Porpodas
committed
[SandboxVec][DAG][NFC] Rename enumerators
1 parent bb8df02 commit 267e852

File tree

2 files changed

+25
-25
lines changed

2 files changed

+25
-25
lines changed

llvm/include/llvm/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.h

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -171,13 +171,13 @@ class DependencyGraph {
171171
std::unique_ptr<BatchAAResults> BatchAA;
172172

173173
enum class DependencyType {
174-
RAW, ///> Read After Write
175-
WAW, ///> Write After Write
176-
RAR, ///> Read After Read
177-
WAR, ///> Write After Read
178-
CTRL, ///> Control-related dependencies, like with PHIs/Terminators
179-
OTHER, ///> Currently used for stack related instrs
180-
NONE, ///> No memory/other dependency
174+
ReadAfterWrite, ///> Memory dependency write -> read
175+
WriteAfterWrite, ///> Memory dependency write -> write
176+
ReadAfterRead, ///> Memory dependency read -> read
177+
WriteAfterRead, ///> Memory dependency read -> write
178+
Control, ///> Control-related dependency, like with PHI/Terminator
179+
Other, ///> Currently used for stack related instrs
180+
None, ///> No memory/other dependency
181181
};
182182
/// \Returns the dependency type depending on whether instructions may
183183
/// read/write memory or whether they are some specific opcode-related

llvm/lib/Transforms/Vectorize/SandboxVectorizer/DependencyGraph.cpp

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -56,23 +56,23 @@ DependencyGraph::getRoughDepType(Instruction *FromI, Instruction *ToI) {
5656
// TODO: Perhaps compile-time improvement by skipping if neither is mem?
5757
if (FromI->mayWriteToMemory()) {
5858
if (ToI->mayReadFromMemory())
59-
return DependencyType::RAW;
59+
return DependencyType::ReadAfterWrite;
6060
if (ToI->mayWriteToMemory())
61-
return DependencyType::WAW;
61+
return DependencyType::WriteAfterWrite;
6262
} else if (FromI->mayReadFromMemory()) {
6363
if (ToI->mayWriteToMemory())
64-
return DependencyType::WAR;
64+
return DependencyType::WriteAfterRead;
6565
if (ToI->mayReadFromMemory())
66-
return DependencyType::RAR;
66+
return DependencyType::ReadAfterRead;
6767
}
6868
if (isa<sandboxir::PHINode>(FromI) || isa<sandboxir::PHINode>(ToI))
69-
return DependencyType::CTRL;
69+
return DependencyType::Control;
7070
if (ToI->isTerminator())
71-
return DependencyType::CTRL;
71+
return DependencyType::Control;
7272
if (DGNode::isStackSaveOrRestoreIntrinsic(FromI) ||
7373
DGNode::isStackSaveOrRestoreIntrinsic(ToI))
74-
return DependencyType::OTHER;
75-
return DependencyType::NONE;
74+
return DependencyType::Other;
75+
return DependencyType::None;
7676
}
7777

7878
static bool isOrdered(Instruction *I) {
@@ -106,10 +106,10 @@ bool DependencyGraph::alias(Instruction *SrcI, Instruction *DstI,
106106
? ModRefInfo::Mod
107107
: Utils::aliasAnalysisGetModRefInfo(*BatchAA, SrcI, *DstLocOpt);
108108
switch (DepType) {
109-
case DependencyType::RAW:
110-
case DependencyType::WAW:
109+
case DependencyType::ReadAfterWrite:
110+
case DependencyType::WriteAfterWrite:
111111
return isModSet(SrcModRef);
112-
case DependencyType::WAR:
112+
case DependencyType::WriteAfterRead:
113113
return isRefSet(SrcModRef);
114114
default:
115115
llvm_unreachable("Expected only RAW, WAW and WAR!");
@@ -119,21 +119,21 @@ bool DependencyGraph::alias(Instruction *SrcI, Instruction *DstI,
119119
bool DependencyGraph::hasDep(Instruction *SrcI, Instruction *DstI) {
120120
DependencyType RoughDepType = getRoughDepType(SrcI, DstI);
121121
switch (RoughDepType) {
122-
case DependencyType::RAR:
122+
case DependencyType::ReadAfterRead:
123123
return false;
124-
case DependencyType::RAW:
125-
case DependencyType::WAW:
126-
case DependencyType::WAR:
124+
case DependencyType::ReadAfterWrite:
125+
case DependencyType::WriteAfterWrite:
126+
case DependencyType::WriteAfterRead:
127127
return alias(SrcI, DstI, RoughDepType);
128-
case DependencyType::CTRL:
128+
case DependencyType::Control:
129129
// Adding actual dep edges from PHIs/to terminator would just create too
130130
// many edges, which would be bad for compile-time.
131131
// So we ignore them in the DAG formation but handle them in the
132132
// scheduler, while sorting the ready list.
133133
return false;
134-
case DependencyType::OTHER:
134+
case DependencyType::Other:
135135
return true;
136-
case DependencyType::NONE:
136+
case DependencyType::None:
137137
return false;
138138
}
139139
}

0 commit comments

Comments
 (0)