clean up removal

Author: akuhlens

flang/include/flang/Parser/message.h

@@ -61,9 +61,8 @@ class MessageFixedText {
     severity_ = severity;
     return *this;
   }
-
   bool IsFatal() const {
-    return severity() == Severity::Error || severity() == Severity::Todo;
+    return severity_ == Severity::Error || severity_ == Severity::Todo;
   }
 
 private:
@@ -114,14 +113,14 @@ class MessageFormattedText {
   MessageFormattedText &operator=(const MessageFormattedText &) = default;
   MessageFormattedText &operator=(MessageFormattedText &&) = default;
   const std::string &string() const { return string_; }
+  bool IsFatal() const {
+    return severity_ == Severity::Error || severity_ == Severity::Todo;
+  }
   Severity severity() const { return severity_; }
   MessageFormattedText &set_severity(Severity severity) {
     severity_ = severity;
     return *this;
   }
-  bool IsFatal(bool warningsAreErrors = false) const {
-    return severity() == Severity::Error || severity() == Severity::Todo;
-  }
   std::string MoveString() { return std::move(string_); }
   bool operator==(const MessageFormattedText &that) const {
     return severity_ == that.severity_ && string_ == that.string_;

flang/lib/Parser/message.cpp

@@ -294,8 +294,6 @@ static std::string HintLanguageControlFlag(
 static constexpr int MAX_CONTEXTS_EMITTED{2};
 static constexpr bool OMIT_SHARED_CONTEXTS{true};
 
-// We think it is confusing to users to display warnings and other
-// diagnostics as errors. Don't use EffectiveSeverity() here.
 void Message::Emit(llvm::raw_ostream &o, const AllCookedSources &allCooked,
     bool echoSourceLine,
     const common::LanguageFeatureControl *hintFlagPtr) const {