Skip to content

Commit 272506d

Browse files
committed
fix review
1 parent 529e5af commit 272506d

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

clang-tools-extra/clang-tidy/utils/ExceptionAnalyzer.cpp

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -320,8 +320,9 @@ bool isQualificationConvertiblePointer(QualType From, QualType To,
320320
} // namespace
321321

322322
static bool canThrow(const FunctionDecl *Func) {
323-
// consteval specifies every call to the function must produce a compile-time
324-
// constant. compile-time constant cannot be evaluate a throw expression.
323+
// consteval specifies that every call to the function must produce a
324+
// compile-time constant, which cannot evaluate a throw expression without
325+
// producing a compilation error.
325326
if (Func->isConsteval())
326327
return false;
327328

clang-tools-extra/docs/ReleaseNotes.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -164,7 +164,7 @@ Changes in existing checks
164164

165165
- Improved :doc:`bugprone-exception-escape
166166
<clang-tidy/checks/bugprone/exception-escape>` by fixing false positives
167-
when consteval function with throw statements.
167+
when a consteval function with throw statements.
168168

169169
- Improved :doc:`bugprone-forwarding-reference-overload
170170
<clang-tidy/checks/bugprone/forwarding-reference-overload>` check by fixing

0 commit comments

Comments
 (0)