change type constraint of bitcast

Author: jacquesguan

mlir/include/mlir/Dialect/Arith/IR/ArithOps.td

@@ -1394,7 +1394,7 @@ def Arith_IndexCastUIOp
 
 // Bitcast can convert between memrefs of signless integers and floats.
 def BitcastTypeConstraint : TypeConstraint<Or<[
-        SignlessIntegerOrFloatLike.predicate,
+        SignlessInteger.predicate, FloatLike.predicate,
         MemRefOf<[AnySignlessInteger, AnyFloat]>.predicate]>,
     "signless-integer-or-float-like or memref of signless-integer or float">;
 

mlir/include/mlir/Dialect/Tensor/IR/TensorOps.td

@@ -75,8 +75,10 @@ def Tensor_BitcastOp : Tensor_Op<"bitcast", [
     ```
   }];
 
-  let arguments = (ins AnyTensor:$source);
-  let results = (outs AnyTensor:$dest);
+  let arguments = (ins TensorOf<[AnySignlessInteger, AnyUnsignedInteger, 
+                                 AnySignedInteger, AnyFloat]>:$source);
+  let results = (outs TensorOf<[AnySignlessInteger, AnyUnsignedInteger,
+                                AnySignedInteger, AnyFloat]>:$dest);
   let assemblyFormat = "$source attr-dict `:` type($source) `to` type($dest)";
 
   let hasCanonicalizer = 1;

mlir/include/mlir/IR/CommonTypeConstraints.td

@@ -908,6 +908,11 @@ def BoolLike : TypeOrContainer<I1, "bool-like">;
 
 def BoolLikeOfAnyRank : TypeOrContainerOfAnyRank<I1, "bool-like">;
 
+// Type constraint for signless-integer-like types: signless integers, 
+// vectors of signless integers or tensors of signless integers.
+def SignlessInteger : TypeOrValueSemanticsContainer<
+    AnySignlessInteger, "signless-integer">;
+
 // Type constraint for signless-integer-like types: signless integers, indices,
 // vectors of signless integers or indices, tensors of signless integers.
 def SignlessIntegerLike : TypeOrValueSemanticsContainer<

mlir/test/Dialect/Arith/invalid.mlir

@@ -857,15 +857,15 @@ func.func @select_tensor_encoding(
 // -----
 
 func.func @bitcast_index_0(%arg0 : i64) -> index {
-  // expected-error @+1 {{'arith.bitcast' op operand type 'i64' and result type 'index' are cast incompatible}}
+  // expected-error @+1 {{'arith.bitcast' op result #0 must be signless-integer-or-float-like or memref of signless-integer or float, but got 'index'}}
   %0 = arith.bitcast %arg0 : i64 to index
   return %0 : index
 }
 
 // -----
 
 func.func @bitcast_index_1(%arg0 : index) -> i64 {
-  // expected-error @+1 {{'arith.bitcast' op operand type 'index' and result type 'i64' are cast incompatible}}
+  // expected-error @+1 {{'arith.bitcast' op operand #0 must be signless-integer-or-float-like or memref of signless-integer or float, but got 'index'}}
   %0 = arith.bitcast %arg0 : index to i64
   return %0 : i64
 }

mlir/test/Dialect/Tensor/invalid.mlir

@@ -811,15 +811,15 @@ func.func @unpack_static_inner_tile_size_and_dynamic_output_shape(
 // -----
 
 func.func @bitcast_index_0(%arg0 : tensor<?xi64>) -> tensor<?xindex> {
-  // expected-error @+1 {{'tensor.bitcast' op operand type 'tensor<?xi64>' and result type 'tensor<?xindex>' are cast incompatible}}
+  // expected-error @+1 {{'tensor.bitcast' op result #0 must be tensor of signless integer or unsigned integer or signed integer or floating-point values, but got 'tensor<?xindex>'}}
   %0 = tensor.bitcast %arg0 : tensor<?xi64> to tensor<?xindex>
   return %0 : tensor<?xindex>
 }
 
 // -----
 
 func.func @bitcast_index_1(%arg0 : tensor<?xindex>) -> tensor<?xi64> {
-  // expected-error @+1 {{'tensor.bitcast' op operand type 'tensor<?xindex>' and result type 'tensor<?xi64>' are cast incompatible}}
+  // expected-error @+1 {{'tensor.bitcast' op operand #0 must be tensor of signless integer or unsigned integer or signed integer or floating-point values, but got 'tensor<?xindex>'}}
   %0 = tensor.bitcast %arg0 : tensor<?xindex> to tensor<?xi64>
   return %0 : tensor<?xi64>
 }