Corrected set initializations

The same Lit tests are produced as the last commit

Author: GeorgeKA

clang/test/Driver/flang/unsupported_in_flang.f90

@@ -1,7 +1,7 @@
 ! NOTE: This lit test was automatically generated to validate unintentionally exposed arguments to various driver flavours.
 ! NOTE: To make changes, see llvm-project/clang/utils/generate_unsupported_in_drivermode.py from which it was generated.
 ! NOTE: Regenerate this Lit test with the following:
-! NOTE: python llvm-project/clang/utils/generate_unsupported_in_drivermode.py llvm-project/clang/include/clang/Driver/Options.td --llvm-bin llvm-project/build/bin --llvm-tblgen llvm-tblgen
+! NOTE: python generate_unsupported_in_drivermode.py llvm-project/clang/include/clang/Driver/Options.td --llvm-bin llvm-project/build/bin --llvm-tblgen llvm-tblgen
 
 ! RUN: not %clang --driver-mode=flang -fc1 -A -A- -B -C -CC -EB -EL -Eonly -F -faapcs-bitfield-load -G -G= -H -K -L -M -MD -MF -MG -MJ -MM -MMD -MP -MQ -MT -MV -Mach -Q -Qn -Qunused-arguments -Qy -T -V -X -Xanalyzer -Xarch_ -Xarch_device -Xarch_host -Xassembler -Xclang -Xcuda-fatbinary -Xcuda-ptxas -Xflang -Xlinker -Xoffload-linker -Xopenmp-target -Xopenmp-target= -Xpreprocessor -Z -Z-Xlinker-no-demangle -Z-reserved-lib-cckext -Z-reserved-lib-stdc++ -Zlinker-input --CLASSPATH --CLASSPATH= -- -### /AI /Brepro /Brepro- /Bt /Bt+ /C /EH /EP /F /FA /FC /FI /FR /FS /FU /Fa /Fd /Fe /Fe: /Fi /Fi: /Fm /Fo /Fo: /Fp /Fp: /Fr /Fx /G1 /G2 /GA /GF /GF- /GH /GL /GL- /GR /GR- /GS /GS- /GT /GX /GX-  - < /dev/null 2>&1 | FileCheck -check-prefix=FC1OptionCHECK-COUNT-100 %s
 

clang/test/Driver/unsupported_in_drivermode.c

@@ -1,7 +1,7 @@
 // NOTE: This lit test was automatically generated to validate unintentionally exposed arguments to various driver flavours.
 // NOTE: To make changes, see llvm-project/clang/utils/generate_unsupported_in_drivermode.py from which it was generated.
 // NOTE: Regenerate this Lit test with the following:
-// NOTE: python llvm-project/clang/utils/generate_unsupported_in_drivermode.py llvm-project/clang/include/clang/Driver/Options.td --llvm-bin llvm-project/build/bin --llvm-tblgen llvm-tblgen
+// NOTE: python generate_unsupported_in_drivermode.py llvm-project/clang/include/clang/Driver/Options.td --llvm-bin llvm-project/build/bin --llvm-tblgen llvm-tblgen
 
 // RUN: not %clang -cc1as -A -A- -B -C -CC -D -E -EB -EL -Eonly -F -faapcs-bitfield-load -G -G= -H -J -K -L -M -MD -MF -MG -MJ -MM -MMD -MP -MQ -MT -MV -Mach -O -O0 -O4 -O -ObjC -ObjC++ -Ofast -P -Q -Qn -Qunused-arguments -Qy -R -Rpass= -Rpass-analysis= -Rpass-missed= -S -T -U -V -WCL4 -W -Wa, -Wall -Wdeprecated -Wframe-larger-than -Wframe-larger-than= -Winvalid-constexpr -Winvalid-gnu-asm-cast -Wl, -Wlarge-by-value-copy= -Wlarge-by-value-copy -Wlarger-than- -Wlarger-than= -Wno-deprecated -Wno-invalid-constexpr -Wno-nonportable-cfstrings -Wno-rewrite-macros -Wno-system-headers -Wno-write-strings -Wnonportable-cfstrings -Wp, -Wsystem-headers -Wsystem-headers-in-module= -Wundef-prefix= -Wwrite-strings -X -Xanalyzer -Xarch_ -Xarch_device -Xarch_host -Xassembler -Xclang -Xcuda-fatbinary -Xcuda-ptxas -Xflang -Xlinker -Xoffload-linker -Xopenmp-target -Xopenmp-target= -Xpreprocessor -Z -Z-Xlinker-no-demangle -Z-reserved-lib-cckext -Z-reserved-lib-stdc++ -Zlinker-input --CLASSPATH --CLASSPATH= -- -###  - < /dev/null 2>&1 | FileCheck -check-prefix=CC1AsOptionCHECK-COUNT-100 %s
 

clang/utils/generate_unsupported_in_drivermode.py

@@ -120,12 +120,11 @@ def find_groups(options_dictionary, option):
     Return: A set including the group found for the option
     """
     group_list = options_dictionary[option]["Group"]
-    group_set = set()
 
     if group_list is None:
         return None
     found_group = group_list["def"]
-    group_set.add(found_group)
+    group_set = {found_group}
 
     sub_group_set = find_groups(options_dictionary, found_group)
     if sub_group_set is None:
@@ -169,7 +168,7 @@ def get_lit_test_note(test_visibility):
         f"{test_prefix}NOTE: To make changes, see llvm-project/clang/utils/generate_unsupported_in_drivermode.py"
         + " from which it was generated.\n"
         f"{test_prefix}NOTE: Regenerate this Lit test with the following:\n"
-        f"{test_prefix}NOTE: python llvm-project/clang/utils/generate_unsupported_in_drivermode.py "
+        f"{test_prefix}NOTE: python generate_unsupported_in_drivermode.py "
         + "llvm-project/clang/include/clang/Driver/Options.td --llvm-bin llvm-project/build/bin --llvm-tblgen llvm-tblgen\n\n"
     )
 
@@ -371,7 +370,7 @@ def validate_file(path):
 # Iterate the options list and find which drivers shouldn't be visible to each option
 for option in options_dictionary["!instanceof"]["Option"]:
     kind = options_dictionary[option]["Kind"]["def"]
-    tmp_visibility_set = set()
+    tmp_visibility_set = set(())
     option_name = options_dictionary[option]["Name"]
 
     # There are a few conditions that make an option unsuitable to test in this script
@@ -432,9 +431,9 @@ def validate_file(path):
     driver_data.supported_sequence.sort(key=len, reverse=True)
 
 # For a given driver, this script cannot generate tests for unsupported options whose option "Name" have a prefix that
-# corresponds to a supported option / visible option of Kind *JOINED*. These driver-option pairs are removed here.
+# corresponds to a supported/visible option of Kind *JOINED*. These driver-option pairs are removed here.
 # The reason is that those options will be parsed as if they were the corresponding prefixed options with a value,
-# and thus would not error would be triggered.
+# and thus no error would be triggered.
 # Example: Option "O_flag" is not visible to FlangOption, but option "O" is visible to FlangOption.
 #          Attempting to test this:
 #            clang --driver-mode=flang -O_flag -### -x c++ -c - < /dev/null 2>&1