Lower to pointer type

Author: Jaddyen

mlir/include/mlir/Dialect/EmitC/IR/EmitC.td

@@ -1267,7 +1267,8 @@ def EmitC_GetGlobalOp : EmitC_Op<"get_global",
   }];
 
   let arguments = (ins FlatSymbolRefAttr:$name);
-  let results = (outs AnyTypeOf<[EmitC_ArrayType, EmitC_LValueType]>:$result);
+  let results = (outs AnyTypeOf<[EmitC_ArrayType, EmitC_LValueType,
+                                 EmitC_PointerType]>:$result);
   let assemblyFormat = "$name `:` type($result) attr-dict";
 }
 
@@ -1686,7 +1687,8 @@ def EmitC_GetFieldOp
   }];
 
   let arguments = (ins FlatSymbolRefAttr:$field_name);
-  let results = (outs AnyTypeOf<[EmitC_ArrayType, EmitC_LValueType]>:$result);
+  let results = (outs AnyTypeOf<[EmitC_ArrayType, EmitC_LValueType,
+                                 EmitC_PointerType]>:$result);
   let assemblyFormat = "$field_name `:` type($result) attr-dict";
 }
 

mlir/lib/Conversion/MemRefToEmitC/MemRefToEmitC.cpp

@@ -153,7 +153,7 @@ struct ConvertGetGlobal final
     MemRefType opTy = op.getType();
     Type resultTy = convertMemRefType(opTy, getTypeConverter());
     if (opTy.getRank() == 0)
-      resultTy = emitc::LValueType::get(resultTy);
+      resultTy = emitc::PointerType::get(resultTy);
 
     if (!resultTy) {
       return rewriter.notifyMatchFailure(op.getLoc(),

mlir/lib/Dialect/EmitC/IR/EmitC.cpp

@@ -1248,6 +1248,15 @@ GetGlobalOp::verifySymbolUses(SymbolTableCollection &symbolTable) {
   }
 
   // global has non-array type
+  if (auto pointerType = llvm::dyn_cast<PointerType>(resultType)) {
+    if (pointerType.getPointee() != globalType) {
+      return emitOpError("on pointer type expects result pointee type ")
+             << pointerType.getPointee() << " to match type " << globalType
+             << " of the global @" << getName();
+    }
+    return success();
+  }
+
   auto lvalueType = dyn_cast<LValueType>(resultType);
   if (!lvalueType || lvalueType.getValueType() != globalType)
     return emitOpError("on non-array type expects result inner type ")