Skip to content

Commit 2988099

Browse files
committed
Address review comments
1 parent 38286f3 commit 2988099

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

clang/lib/Sema/SemaOpenMP.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -14718,7 +14718,7 @@ bool SemaOpenMP::checkTransformableLoopSequence(
1471814718
return false;
1471914719

1472014720
// Diagnose an empty loop sequence.
14721-
if (SeqAnalysis.LoopSeqSize <= 0) {
14721+
if (!SeqAnalysis.LoopSeqSize) {
1472214722
Diag(AStmt->getBeginLoc(), diag::err_omp_empty_loop_sequence)
1472314723
<< getOpenMPDirectiveName(Kind);
1472414724
return false;
@@ -16118,7 +16118,6 @@ StmtResult SemaOpenMP::ActOnOpenMPFuseDirective(ArrayRef<OMPClause *> Clauses,
1611816118
if (NeedsNewVD) {
1611916119
VD = buildVarDecl(SemaRef, SourceLocation(), IVType, Name);
1612016120
SemaRef.AddInitializerToDecl(VD, TransformedExpr, false);
16121-
1612216121
} else {
1612316122
// Create a unique variable name
1612416123
DeclRefExpr *DRE = cast<DeclRefExpr>(TransformedExpr);
@@ -16434,7 +16433,7 @@ StmtResult SemaOpenMP::ActOnOpenMPFuseDirective(ArrayRef<OMPClause *> Clauses,
1643416433
// Pre-fusion and post-fusion loops are inserted in order exploiting their
1643516434
// symmetry, along with their corresponding transformation pre-inits if
1643616435
// needed. The fused loop is added between the two regions.
16437-
for (unsigned I = 0; I < SeqAnalysis.LoopSeqSize; ++I) {
16436+
for (unsigned I : llvm::seq<unsigned>(SeqAnalysis.LoopSeqSize)) {
1643816437
if (I >= FirstVal - 1 && I < FirstVal + CountVal - 1) {
1643916438
// Update the Transformation counter to skip already treated
1644016439
// loop transformations

0 commit comments

Comments
 (0)