Skip to content

Commit 29eb893

Browse files
Joao SaffranJoao Saffran
authored andcommitted
cleanup
1 parent af6aa53 commit 29eb893

File tree

3 files changed

+1
-20
lines changed

3 files changed

+1
-20
lines changed

llvm/include/llvm/Frontend/HLSL/HLSLBinding.h

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,6 @@ class BindingInfo {
5757
}
5858
// Size == -1 means unbounded array
5959
LLVM_ABI std::optional<uint32_t> findAvailableBinding(int32_t Size);
60-
LLVM_ABI bool isBound(BindingRange B);
6160
};
6261

6362
struct BindingSpaces {
@@ -96,8 +95,6 @@ class BindingInfo {
9695
LLVM_ABI std::optional<uint32_t>
9796
findAvailableBinding(dxil::ResourceClass RC, uint32_t Space, int32_t Size);
9897

99-
LLVM_ABI bool isBound(dxil::ResourceClass RC, uint32_t Space, BindingRange B);
100-
10198
friend class BindingInfoBuilder;
10299
};
103100

llvm/lib/Frontend/HLSL/HLSLBinding.cpp

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -66,22 +66,6 @@ BindingInfo::RegisterSpace::findAvailableBinding(int32_t Size) {
6666
return std::nullopt;
6767
}
6868

69-
bool BindingInfo::RegisterSpace::isBound(BindingRange B) {
70-
for (BindingRange &R : FreeRanges) {
71-
if (B.LowerBound >= R.LowerBound && B.LowerBound < R.UpperBound &&
72-
B.UpperBound > R.LowerBound && B.UpperBound <= R.UpperBound)
73-
return false;
74-
}
75-
return true;
76-
}
77-
78-
bool BindingInfo::isBound(dxil::ResourceClass RC, uint32_t Space,
79-
BindingRange B) {
80-
BindingSpaces &BS = getBindingSpaces(RC);
81-
RegisterSpace &RS = BS.getOrInsertSpace(Space);
82-
return RS.isBound(B);
83-
}
84-
8569
BindingInfo BindingInfoBuilder::calculateBindingInfo(
8670
llvm::function_ref<void(const BindingInfoBuilder &Builder,
8771
const Binding &Overlapping)>

llvm/test/CodeGen/DirectX/rootsignature-validation-fail-static-sampler-range.ll

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ entry:
1010
!0 = !{ptr @CSMain, !1, i32 2}
1111
!1 = !{!2, !3}
1212
!2 = !{ !"StaticSampler", i32 5, i32 4, i32 5, i32 3, float 0x3FF7CCCCC0000000, i32 10, i32 2, i32 1, float -1.270000e+02, float 1.220000e+02, i32 42, i32 0, i32 0 }
13-
!3 = !{ !"StaticSampler", i32 4, i32 2, i32 3, i32 5, float 0x3FF6CCCCC0000000, i32 9, i32 3, i32 2, float -1.280000e+02, float 1.280000e+02, i32 42, i32 0, i32 0 }
13+
!3 = !{ !"StaticSampler", i32 4, i32 2, i32 3, i32 5, float 0x3FF6CCCCC0000000, i32 9, i32 3, i32 2, float -1.280000e+02, float 1.280000e+02, i32 42, i32 0, i32 0 }

0 commit comments

Comments
 (0)