Apply review feedback

Author: andykaylor

clang/lib/CIR/CodeGen/Address.h

@@ -17,6 +17,7 @@
 #include "mlir/IR/Value.h"
 #include "clang/AST/CharUnits.h"
 #include "clang/CIR/Dialect/IR/CIRTypes.h"
+#include "clang/CIR/MissingFeatures.h"
 #include "llvm/ADT/PointerIntPair.h"
 
 namespace clang::CIRGen {
@@ -93,7 +94,7 @@ class Address {
   /// Return the pointer contained in this class after authenticating it and
   /// adding offset to it if necessary.
   mlir::Value emitRawPointer() const {
-    // TODO(cir): update this class with latest traditional LLVM codegen bits
+    assert(!cir::MissingFeatures::addressPointerAuthInfo());
     return getBasePointer();
   }
 

clang/lib/CIR/CodeGen/CIRGenExprCXX.cpp

@@ -174,8 +174,8 @@ RValue CIRGenFunction::emitCXXMemberOrOperatorMemberCallExpr(
       // CIRGen does not pass CallOrInvoke here (different from OG LLVM codegen)
       // because in practice it always null even in OG.
       emitCXXDestructorCall(globalDecl, callee, thisPtr.getPointer(), thisTy,
-                            /*ImplicitParam=*/nullptr,
-                            /*ImplicitParamTy=*/QualType(), ce);
+                            /*implicitParam=*/nullptr,
+                            /*implicitParamTy=*/QualType(), ce);
     }
     return RValue::get(nullptr);
   }

clang/lib/CIR/CodeGen/CIRGenFunction.cpp

@@ -682,8 +682,8 @@ void CIRGenFunction::emitDestructorBody(FunctionArgList &args) {
     enterDtorCleanups(dtor, Dtor_Deleting);
     if (haveInsertPoint()) {
       QualType thisTy = dtor->getFunctionObjectParameterType();
-      emitCXXDestructorCall(dtor, Dtor_Complete, /*ForVirtualBase=*/false,
-                            /*Delegating=*/false, loadCXXThisAddress(), thisTy);
+      emitCXXDestructorCall(dtor, Dtor_Complete, /*forVirtualBase=*/false,
+                            /*delegating=*/false, loadCXXThisAddress(), thisTy);
     }
     return;
   }

clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp

@@ -483,11 +483,8 @@ mlir::Value CIRGenItaniumCXXABI::emitVirtualDestructorCall(
   const cir::FuncType &fnTy = cgm.getTypes().getFunctionType(*fnInfo);
   auto callee = CIRGenCallee::forVirtual(callExpr, globalDecl, thisAddr, fnTy);
 
-  QualType thisTy;
-  if (callExpr)
-    thisTy = callExpr->getObjectType();
-  else
-    thisTy = delExpr->getDestroyedType();
+  QualType thisTy =
+      callExpr ? callExpr->getObjectType() : delExpr->getDestroyedType();
 
   cgf.emitCXXDestructorCall(globalDecl, callee, thisAddr.emitRawPointer(),
                             thisTy, nullptr, QualType(), nullptr);