Skip to content

Commit 2acc2b5

Browse files
add todo
1 parent aa7076c commit 2acc2b5

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

llvm/lib/Target/X86/MCA/X86CustomBehaviour.cpp

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,9 @@ void X86InstrPostProcess::setMemBarriers(std::unique_ptr<Instruction> &Inst,
3838

3939
void X86InstrPostProcess::useStackEngine(std::unique_ptr<Instruction> &Inst,
4040
const MCInst &MCI) {
41+
// TODO(boomanaiden154): We currently do not handle PUSHF/POPF because we
42+
// have not done the necessary benchmarking to see if they are also
43+
// optimized by the stack engine.
4144
if (X86::isPOP(MCI.getOpcode()) || X86::isPUSH(MCI.getOpcode())) {
4245
auto *StackRegisterDef =
4346
llvm::find_if(Inst->getDefs(), [](const WriteState &State) {

0 commit comments

Comments
 (0)