Make shouldUseMicrosoftCCforMangling generic to be used for ABI decisions beyond mangling.

Author: Prabhuk

clang/include/clang/Basic/TargetInfo.h

@@ -253,7 +253,7 @@ class TargetInfo : public TransferrableTargetInfo,
   const char *MCountName;
   unsigned char RegParmMax, SSERegParmMax;
   TargetCXXABI TheCXXABI;
-  bool UseMicrosoftManglingForC = false;
+  bool UseMicrosoftCCForC = false;
   const LangASMap *AddrSpaceMap;
 
   mutable StringRef PlatformName;
@@ -1345,10 +1345,8 @@ class TargetInfo : public TransferrableTargetInfo,
     return TheCXXABI;
   }
 
-  /// Should the Microsoft mangling scheme be used for C Calling Convention.
-  bool shouldUseMicrosoftCCforMangling() const {
-    return UseMicrosoftManglingForC;
-  }
+  /// Should the Microsoft C Calling Convention be used.
+  bool shouldUseMicrosoftCCforC() const { return UseMicrosoftCCForC; }
 
   /// Target the specified CPU.
   ///

clang/lib/AST/Mangle.cpp

@@ -74,7 +74,7 @@ static CCMangling getCallingConvMangling(const ASTContext &Context,
       if (FD->isMain() && FD->getNumParams() == 2)
         return CCM_WasmMainArgcArgv;
 
-  if (!TI.shouldUseMicrosoftCCforMangling())
+  if (!TI.shouldUseMicrosoftCCforC())
     return CCM_Other;
 
   if (Context.getLangOpts().CPlusPlus && !isExternC(ND) &&

clang/lib/Basic/Targets/OSTargets.h

@@ -817,7 +817,7 @@ class LLVM_LIBRARY_VISIBILITY UEFITargetInfo : public OSTargetInfo<Target> {
       : OSTargetInfo<Target>(Triple, Opts) {
     this->WCharType = TargetInfo::UnsignedShort;
     this->WIntType = TargetInfo::UnsignedShort;
-    this->UseMicrosoftManglingForC = true;
+    this->UseMicrosoftCCForC = true;
   }
 };
 
@@ -838,7 +838,7 @@ class LLVM_LIBRARY_VISIBILITY WindowsTargetInfo : public OSTargetInfo<Target> {
       : OSTargetInfo<Target>(Triple, Opts) {
     this->WCharType = TargetInfo::UnsignedShort;
     this->WIntType = TargetInfo::UnsignedShort;
-    this->UseMicrosoftManglingForC = true;
+    this->UseMicrosoftCCForC = true;
   }
 };
 

clang/lib/Sema/SemaChecking.cpp

@@ -4770,7 +4770,7 @@ ExprResult Sema::CheckOSLogFormatStringArg(Expr *Arg) {
 /// target and calling convention.
 static bool checkVAStartABI(Sema &S, unsigned BuiltinID, Expr *Fn) {
   const TargetInfo &TI = S.Context.getTargetInfo();
-  bool IsMicrosoftCC = TI.shouldUseMicrosoftCCforMangling();
+  bool IsMicrosoftCC = TI.shouldUseMicrosoftCCforC();
   const llvm::Triple &TT = TI.getTriple();
   bool IsX64 = TT.getArch() == llvm::Triple::x86_64;
   bool IsAArch64 = (TT.getArch() == llvm::Triple::aarch64 ||

clang/lib/Sema/SemaExpr.cpp

@@ -17990,7 +17990,7 @@ static bool isPotentiallyConstantEvaluatedContext(Sema &SemaRef) {
 static bool funcHasParameterSizeMangling(Sema &S, FunctionDecl *FD) {
   // These manglings are only applicable for targets whcih use Microsoft
   // mangling scheme for C.
-  if (!S.Context.getTargetInfo().shouldUseMicrosoftCCforMangling())
+  if (!S.Context.getTargetInfo().shouldUseMicrosoftCCforC())
     return false;
 
   // If this is C++ and this isn't an extern "C" function, parameters do not