Skip to content

Commit 2b2caf8

Browse files
committed
Fix incorrect parameter descriptions. base_width and base_pitch is number of bytes. base_height is number of rows.
1 parent 101b67a commit 2b2caf8

File tree

1 file changed

+12
-9
lines changed

1 file changed

+12
-9
lines changed

mlir/include/mlir/Dialect/LLVMIR/XeVMOps.td

Lines changed: 12 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -202,9 +202,10 @@ def XeVM_BlockLoad2dOp
202202
The `xevm.blockload2d` operation loads a two dimensional matrix tile
203203
from a base matrix residing in global memory. The parameters are:
204204
$ptr - the base address of the base matrix containing the tile to load
205-
$base_width, $base_height, $base_pitch - the shape of the base matrix.
206-
pitch is the physical stride between the first columns of the current row
207-
and the subsequent row. All units are in bytes.
205+
$base_width - the width of the base matrix in number of bytes.
206+
$base_height - the number of rows in the base matrix
207+
$base_pitch - the physical stride between the first columns of the current
208+
row and the subsequent row in number of bytes.
208209
$x, $y, $tile_width, $tile_height - the starting offsets and shape of
209210
the tile to load in number of elements.
210211
$elem_size_in_bits - the size in bits of the matrix element type
@@ -262,9 +263,10 @@ def XeVM_BlockStore2dOp
262263
The `xevm.blockstore2d` operation stores a two dimensional tile into a
263264
larger matrix residing in global memory. The parameters are:
264265
$ptr - the base address of the target matrix where to store the tile
265-
$base_width, $base_height, $base_pitch - the shape of the target matrix. pitch is the
266-
physical stride between the first columns of the current row and the subsequent row.
267-
All units are in bytes.
266+
$base_width - the width of the base matrix in number of bytes.
267+
$base_height - the number of rows in the base matrix
268+
$base_pitch - the physical stride between the first columns of the current
269+
row and the subsequent row in number of bytes.
268270
$x, $y, $tile_width, $tile_height - the starting offsets and shape of the tile to store
269271
in number of elements.
270272
$elem_size_in_bits - the size in bits of the matrix element
@@ -394,9 +396,10 @@ def XeVM_BlockPrefetch2dOp
394396
The `xevm.blockprefetch2d` operation prefetches a two dimensional tile
395397
from a larger base matrix residing in global memory. The parameters are:
396398
$ptr - the base address of the base matrix containing the tile to prefetch
397-
$base_width, $base_height, $base_pitch - the shape of the base matrix.
398-
pitch is the physical stride between the first columns of the current row
399-
and the subsequent row. All units are in bytes.
399+
$base_width - the width of the base matrix in number of bytes.
400+
$base_height - the number of rows in the base matrix
401+
$base_pitch - the physical stride between the first columns of the current
402+
row and the subsequent row in number of bytes.
400403
$x, $y, $tile_width, $tile_height - the starting offsets and shape of tile
401404
to prefetch in number of elements.
402405
$elem_size_in_bits - the size in bits of the matrix element

0 commit comments

Comments
 (0)