[clang] Fix incorrect inferred lifetime_capture_by attr on STL.

We incorrectly annotate the iterator parameter for `insert` method
(`void insert(const_iterator, const value_type& value)`), because
iterator happens to be a gsl-pointer type. This patch fixes it.

Author: hokein

clang/lib/Sema/SemaAttr.cpp

@@ -287,7 +287,12 @@ void Sema::inferLifetimeCaptureByAttribute(FunctionDecl *FD) {
     if (PVD->hasAttr<LifetimeCaptureByAttr>())
       return;
   for (ParmVarDecl *PVD : MD->parameters()) {
-    if (sema::isPointerLikeType(PVD->getType().getNonReferenceType())) {
+    // Methods in standard containers that capture values typically accept
+    // reference-type parameters, e.g., `void push_back(const T& value)`.
+    // We only apply the lifetime_capture_by attribute to parameters of
+    // pointer-like reference types (`const T&`, `T&&`).
+    if (PVD->getType()->isReferenceType() &&
+        sema::isPointerLikeType(PVD->getType().getNonReferenceType())) {
       int CaptureByThis[] = {LifetimeCaptureByAttr::THIS};
       PVD->addAttr(
           LifetimeCaptureByAttr::CreateImplicit(Context, CaptureByThis, 1));

clang/test/AST/attr-lifetime-capture-by.cpp

@@ -48,7 +48,7 @@ std::vector<View> views;
 
 // CHECK:       CXXMethodDecl {{.*}} insert 'void (iterator, View &&)'
 // CHECK-NEXT:           ParmVarDecl {{.*}} 'iterator'
-// CHECK-NEXT:               LifetimeCaptureByAttr {{.*}} Implicit
+// CHECK-NOT:               LifetimeCaptureByAttr {{.*}} Implicit
 // CHECK-NEXT:           ParmVarDecl {{.*}} 'View &&'
 // CHECK-NEXT:               LifetimeCaptureByAttr {{.*}} Implicit
 
@@ -67,7 +67,7 @@ std::vector<ViewTemplate<int>> templated_views;
 
 // CHECK:       CXXMethodDecl {{.*}} insert 'void (iterator, ViewTemplate<int> &&)'
 // CHECK-NEXT:           ParmVarDecl {{.*}} 'iterator'
-// CHECK-NEXT:               LifetimeCaptureByAttr {{.*}} Implicit
+// CHECK-NOT:               LifetimeCaptureByAttr {{.*}} Implicit
 // CHECK-NEXT:           ParmVarDecl {{.*}} 'ViewTemplate<int> &&'
 // CHECK-NEXT:               LifetimeCaptureByAttr {{.*}} Implicit
 
@@ -84,7 +84,7 @@ std::vector<int*> pointers;
 
 // CHECK:       CXXMethodDecl {{.*}} insert 'void (iterator, int *&&)'
 // CHECK-NEXT:           ParmVarDecl {{.*}} 'iterator'
-// CHECK-NEXT:               LifetimeCaptureByAttr {{.*}} Implicit
+// CHECK-NOT:               LifetimeCaptureByAttr {{.*}} Implicit
 // CHECK-NEXT:           ParmVarDecl {{.*}} 'int *&&'
 // CHECK-NEXT:               LifetimeCaptureByAttr {{.*}} Implicit
 
@@ -100,6 +100,6 @@ std::vector<int> ints;
 
 // CHECK:       CXXMethodDecl {{.*}} insert 'void (iterator, int &&)'
 // CHECK-NEXT:           ParmVarDecl {{.*}} 'iterator'
-// CHECK-NEXT:               LifetimeCaptureByAttr {{.*}} Implicit
+// CHECK-NOT:               LifetimeCaptureByAttr {{.*}} Implicit
 // CHECK-NEXT:           ParmVarDecl {{.*}} 'int &&'
 // CHECK-NOT:   LifetimeCaptureByAttr