Call dlclose() only when dlsym() fails.

xingxue-ibm · xingxue-ibm · commit 2bb223edb6a3 · 2024-10-17T14:59:40.000-04:00
diff --git a/libunwind/src/UnwindCursor.hpp b/libunwind/src/UnwindCursor.hpp
@@ -2151,8 +2151,8 @@ bool UnwindCursor<A, R>::getInfoFromTBTable(pint_t pc, R &registers) {
         if (xlcPersonalityV0 == NULL) {
           _LIBUNWIND_TRACE_UNWINDING("dlsym() failed with errno=%d\n", errno);
           assert(0 && "dlsym() failed");
+          dlclose(libHandle);
         }
-        dlclose(libHandle);
         errno = saveErrno;
       }
       xlcPersonalityV0InitLock.unlock();

Original file line number	Diff line number	Diff line change
`@@ -2151,8 +2151,8 @@ bool UnwindCursor<A, R>::getInfoFromTBTable(pint_t pc, R &registers) {`
`2151`	`2151`	`if (xlcPersonalityV0 == NULL) {`
`2152`	`2152`	`_LIBUNWIND_TRACE_UNWINDING("dlsym() failed with errno=%d\n", errno);`
`2153`	`2153`	`assert(0 && "dlsym() failed");`
	`2154`	`+ dlclose(libHandle);`
`2154`	`2155`	`}`
`2155`		`- dlclose(libHandle);`
`2156`	`2156`	`errno = saveErrno;`
`2157`	`2157`	`}`
`2158`	`2158`	`xlcPersonalityV0InitLock.unlock();`