Skip to content

Commit 2bc1450

Browse files
committed
review: improve testing readability and strictness
1 parent 9197d82 commit 2bc1450

File tree

2 files changed

+41
-24
lines changed

2 files changed

+41
-24
lines changed

llvm/test/tools/llvm-objcopy/DXContainer/extract-section-basic.test

Lines changed: 25 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -16,28 +16,42 @@
1616
## void main() {}
1717
## ```
1818

19+
# CHECK: Header:
20+
# CHECK-NEXT: Hash:
21+
# CHECK: Version:
22+
# CHECK-NEXT: Major: 1
23+
# CHECK-NEXT: Minor: 0
24+
# CHECK-NEXT: FileSize: 68
25+
# CHECK-NEXT: PartCount: 1
26+
# CHECK-NEXT: PartOffsets: [ 36 ]
27+
# CHECK-NEXT: Parts:
28+
# CHECK-NOT: DXIL
29+
# CHECK-NOT: SFI0
30+
# CHECK-NOT: HASH
31+
# CHECK-NOT: ISG1
32+
# CHECK-NOT: OSG1
33+
# CHECK: Name: RTS0
34+
# CHECK-NEXT Size: 24
35+
# CHECK-NEXT RootSignature:
36+
# CHECK-NEXT Version: 2
37+
# CHECK-NEXT NumRootParameters: 0
38+
# CHECK-NEXT RootParametersOffset: 24
39+
# CHECK-NEXT NumStaticSamplers: 0
40+
# CHECK-NEXT StaticSamplersOffset: 24
41+
# CHECK-NEXT Parameters: []
42+
# CHECK-NOT: PSV0
43+
1944
--- !dxcontainer
2045
Header:
2146
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
2247
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
2348
Version:
2449
Major: 1
2550
Minor: 0
26-
# CHECK: FileSize: 68
2751
FileSize: 1984
28-
# CHECK-NEXT: PartCount: 1
29-
# CHECK-NEXT: PartOffsets: [ 36 ]
3052
PartCount: 7
3153
PartOffsets: [ 60, 1792, 1808, 1836, 1852, 1868, 1900 ]
32-
# CHECK-NEXT: Parts:
3354
Parts:
34-
# CHECK-NOT: DXIL
35-
# CHECK-NOT: SFI0
36-
# CHECK-NOT: HASH
37-
# CHECK-NOT: ISG1
38-
# CHECK-NOT: OSG1
39-
# CHECK: Name: RTS0
40-
# CHECK-NOT: PSV0
4155
- Name: DXIL
4256
Size: 1724
4357
Program:

llvm/test/tools/llvm-objcopy/DXContainer/extract-section-headers.test

Lines changed: 16 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,30 +6,33 @@
66
# RUN: obj2yaml %t.fke1.out | FileCheck %s --check-prefixes=CHECK,FKE1
77
# RUN: obj2yaml %t.fke4.out | FileCheck %s --check-prefixes=CHECK,FKE4
88

9+
# FKE1: FileSize: 52
10+
# FKE4: FileSize: 1732
11+
# CHECK-NEXT: PartCount: 1
12+
# CHECK-NEXT: PartOffsets: [ 36 ]
13+
# CHECK-NEXT: Parts:
14+
15+
# CHECK-NOT: FKE0
16+
# FKE1: Name: FKE1
17+
# FKE4-NOT: FKE1
18+
# CHECK-NOT: FKE2
19+
# CHECK-NOT: FKE3
20+
# FKE1-NOT: FKE4
21+
# FKE4: Name: FKE4
22+
# CHECK-NOT: FKE5
23+
# CHECK-NOT: DXIL
24+
925
--- !dxcontainer
1026
Header:
1127
Hash: [ 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0,
1228
0x0, 0x0, 0x0, 0x0, 0x0, 0x0 ]
1329
Version:
1430
Major: 1
1531
Minor: 0
16-
## FKE1: FileSize: 52
17-
## FKE4: FileSize: 1732
1832
FileSize: 1996
19-
# CHECK: PartCount: 1
20-
# CHECK-NEXT: PartOffsets: [ 36 ]
2133
PartCount: 7
2234
PartOffsets: [ 60, 76, 92, 108, 236, 1932, 1960 ]
23-
# CHECK-NEXT: Parts:
2435
Parts:
25-
# CHECK-NOT: FKE0
26-
# FKE1: Name: FKE1
27-
# FKE4-NOT: FKE1
28-
# CHECK-NOT: FKE2
29-
# CHECK-NOT: FKE3
30-
# FKE1-NOT: FKE4
31-
# FKE4: Name: FKE4
32-
# CHECK-NOT: FKE5
3336
- Name: FKE0
3437
Size: 8
3538
- Name: FKE1

0 commit comments

Comments
 (0)