Skip to content

Commit 2bdceba

Browse files
apply code review suggestions
1 parent 6f121f2 commit 2bdceba

File tree

2 files changed

+3
-4
lines changed

2 files changed

+3
-4
lines changed

llvm/lib/Target/SPIRV/SPIRVSubtarget.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ void SPIRVSubtarget::initAvailableExtInstSets() {
158158

159159
// Set available extensions after SPIRVSubtarget is created.
160160
void SPIRVSubtarget::initAvailableExtensions(
161-
std::set<SPIRV::Extension::Extension> AllowedExtIds) {
161+
const std::set<SPIRV::Extension::Extension> &AllowedExtIds) {
162162
AvailableExtensions.clear();
163163
AvailableExtensions.insert(AllowedExtIds.begin(), AllowedExtIds.end());
164164

llvm/lib/Target/SPIRV/SPIRVSubtarget.h

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,6 @@ class SPIRVSubtarget : public SPIRVGenSubtargetInfo {
5959

6060
// TODO: Initialise the available extensions, extended instruction sets
6161
// based on the environment settings.
62-
void initAvailableExtensions();
6362
void initAvailableExtInstSets();
6463
void accountForAMDShaderTrinaryMinmax();
6564

@@ -70,8 +69,8 @@ class SPIRVSubtarget : public SPIRVGenSubtargetInfo {
7069
const std::string &FS, const SPIRVTargetMachine &TM);
7170
SPIRVSubtarget &initSubtargetDependencies(StringRef CPU, StringRef FS);
7271

73-
void
74-
initAvailableExtensions(std::set<SPIRV::Extension::Extension> AllowedExtIds);
72+
void initAvailableExtensions(
73+
const std::set<SPIRV::Extension::Extension> &AllowedExtIds);
7574

7675
// Parses features string setting specified subtarget options.
7776
// The definition of this function is auto generated by tblgen.

0 commit comments

Comments
 (0)