address comments

Author: Backl1ght

clang/docs/ReleaseNotes.rst

@@ -703,7 +703,7 @@ Bug Fixes in This Version
   the second clause of a C-style ``for`` loop. (#GH139818)
 - Fixed a bug with constexpr evaluation for structs containing unions in case of C++ modules. (#GH143168)
 - Fixed incorrect token location when emitting diagnostics for tokens expanded from macros. (#GH143216)
-- Fixed an infinite recursion about defaulted constexpr dtor. (#GH141789)
+- Fixed an infinite recursion when checking constexpr destructors. (#GH141789)
 
 Bug Fixes to Compiler Builtins
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

clang/lib/Sema/SemaDeclCXX.cpp

@@ -7161,7 +7161,7 @@ void Sema::CheckCompletedCXXClass(Scope *S, CXXRecordDecl *Record) {
     if (isa<CXXDestructorDecl>(M)) {
       llvm::SmallDenseSet<QualType> Visited;
       auto Check = [&Visited](QualType T, auto &&Check) -> bool {
-        if (!Visited.insert(T.getCanonicalType().getUnqualifiedType()).second)
+        if (!Visited.insert(T->getCanonicalTypeUnqualified()).second)
           return false;
         const CXXRecordDecl *RD =
             T->getBaseElementTypeUnsafe()->getAsCXXRecordDecl();