Skip to content

Commit 2c05190

Browse files
address comments
1 parent ecb21fa commit 2c05190

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

mlir/include/mlir/IR/Block.h

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -273,6 +273,10 @@ class alignas(8) Block : public IRObjectWithUseList<BlockOperand>,
273273
///
274274
/// Note: This function performs a block graph traversal and its complexity
275275
/// linear in the number of blocks in the parent region.
276+
///
277+
/// Note: Reachability is a necessary but insufficient condition for
278+
/// dominance. Do not use this function in places where you need to check for
279+
/// dominance.
276280
bool isReachable(Block *other, SmallPtrSet<Block *, 16> &&except = {});
277281

278282
//===--------------------------------------------------------------------===//

0 commit comments

Comments
 (0)