Skip to content

Commit 2c651ad

Browse files
committed
Revert "[flang] Add -f[no-]unroll-loops flag (#122906)"
This reverts commit 0195ec4.
1 parent a79098b commit 2c651ad

File tree

8 files changed

+5
-96
lines changed

8 files changed

+5
-96
lines changed

clang/include/clang/Driver/Options.td

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4162,9 +4162,9 @@ def ftrap_function_EQ : Joined<["-"], "ftrap-function=">, Group<f_Group>,
41624162
HelpText<"Issue call to specified function rather than a trap instruction">,
41634163
MarshallingInfoString<CodeGenOpts<"TrapFuncName">>;
41644164
def funroll_loops : Flag<["-"], "funroll-loops">, Group<f_Group>,
4165-
HelpText<"Turn on loop unroller">, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>;
4165+
HelpText<"Turn on loop unroller">, Visibility<[ClangOption, CC1Option]>;
41664166
def fno_unroll_loops : Flag<["-"], "fno-unroll-loops">, Group<f_Group>,
4167-
HelpText<"Turn off loop unroller">, Visibility<[ClangOption, CC1Option, FlangOption, FC1Option]>;
4167+
HelpText<"Turn off loop unroller">, Visibility<[ClangOption, CC1Option]>;
41684168
def ffinite_loops: Flag<["-"], "ffinite-loops">, Group<f_Group>,
41694169
HelpText<"Assume all non-trivial loops are finite.">, Visibility<[ClangOption, CC1Option]>;
41704170
def fno_finite_loops: Flag<["-"], "fno-finite-loops">, Group<f_Group>,

clang/lib/Driver/ToolChains/Flang.cpp

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -156,9 +156,9 @@ void Flang::addCodegenOptions(const ArgList &Args,
156156
options::OPT_fno_ppc_native_vec_elem_order,
157157
options::OPT_fppc_native_vec_elem_order,
158158
options::OPT_finit_global_zero,
159-
options::OPT_fno_init_global_zero, options::OPT_ftime_report,
160-
options::OPT_ftime_report_EQ, options::OPT_funroll_loops,
161-
options::OPT_fno_unroll_loops});
159+
options::OPT_fno_init_global_zero,
160+
options::OPT_ftime_report,
161+
options::OPT_ftime_report_EQ});
162162
}
163163

164164
void Flang::addPicOptions(const ArgList &Args, ArgStringList &CmdArgs) const {

flang/include/flang/Frontend/CodeGenOptions.def

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,6 @@ CODEGENOPT(PrepareForThinLTO , 1, 0) ///< Set when -flto=thin is enabled on the
3232
///< compile step.
3333
CODEGENOPT(StackArrays, 1, 0) ///< -fstack-arrays (enable the stack-arrays pass)
3434
CODEGENOPT(LoopVersioning, 1, 0) ///< Enable loop versioning.
35-
CODEGENOPT(UnrollLoops, 1, 0) ///< Enable loop unrolling
3635
CODEGENOPT(AliasAnalysis, 1, 0) ///< Enable alias analysis pass
3736

3837
CODEGENOPT(Underscoring, 1, 1)

flang/lib/Frontend/CompilerInvocation.cpp

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,10 +246,6 @@ static void parseCodeGenArgs(Fortran::frontend::CodeGenOptions &opts,
246246
clang::driver::options::OPT_fno_loop_versioning, false))
247247
opts.LoopVersioning = 1;
248248

249-
opts.UnrollLoops = args.hasFlag(clang::driver::options::OPT_funroll_loops,
250-
clang::driver::options::OPT_fno_unroll_loops,
251-
(opts.OptimizationLevel > 1));
252-
253249
opts.AliasAnalysis = opts.OptimizationLevel > 0;
254250

255251
// -mframe-pointer=none/non-leaf/all option.

flang/lib/Frontend/FrontendActions.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1028,8 +1028,6 @@ void CodeGenAction::runOptimizationPipeline(llvm::raw_pwrite_stream &os) {
10281028
si.registerCallbacks(pic, &mam);
10291029
if (ci.isTimingEnabled())
10301030
si.getTimePasses().setOutStream(ci.getTimingStreamLLVM());
1031-
pto.LoopUnrolling = opts.UnrollLoops;
1032-
pto.LoopInterleaving = opts.UnrollLoops;
10331031
llvm::PassBuilder pb(targetMachine, pto, pgoOpt, &pic);
10341032

10351033
// Attempt to load pass plugins and register their callbacks with PB.

flang/test/Driver/funroll-loops.f90

Lines changed: 0 additions & 5 deletions
This file was deleted.

flang/test/HLFIR/unroll-loops.fir

Lines changed: 0 additions & 42 deletions
This file was deleted.

flang/test/Integration/unroll-loops.f90

Lines changed: 0 additions & 37 deletions
This file was deleted.

0 commit comments

Comments
 (0)