Skip to content

Commit 2c9d19f

Browse files
committed
fixup! Address review comments.
1 parent b8bc3d8 commit 2c9d19f

File tree

2 files changed

+4
-5
lines changed

2 files changed

+4
-5
lines changed

llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6172,8 +6172,8 @@ LegalizerHelper::equalizeVectorShuffleLengths(MachineInstr &MI) {
61726172
if (MaskNumElts < SrcNumElts) {
61736173
// Extend mask to match new destination vector size with
61746174
// undef values.
6175-
SmallVector<int, 16> NewMask(Mask);
6176-
NewMask.resize(SrcNumElts, -1);
6175+
SmallVector<int, 16> NewMask(SrcNumElts, -1);
6176+
llvm::copy(Mask, NewMask.begin());
61776177

61786178
moreElementsVectorDst(MI, SrcTy, 0);
61796179
MIRBuilder.setInstrAndDebugLoc(MI);

llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6476,9 +6476,8 @@ SDValue DAGTypeLegalizer::WidenVecRes_VECTOR_REVERSE(SDNode *N) {
64766476

64776477
// Use VECTOR_SHUFFLE to combine new vector from 'ReverseVal' for
64786478
// fixed-vectors.
6479-
SmallVector<int, 16> Mask(VTNumElts, -1);
6480-
for (unsigned i = 0; i != VTNumElts; ++i)
6481-
Mask[i] = IdxVal + i;
6479+
SmallVector<int, 16> Mask(WidenNumElts, -1);
6480+
std::iota(Mask.begin(), Mask.begin() + VTNumElts, IdxVal);
64826481

64836482
return DAG.getVectorShuffle(WidenVT, dl, ReverseVal, DAG.getUNDEF(WidenVT),
64846483
Mask);

0 commit comments

Comments
 (0)