Apply suggestions from code review

Co-authored-by: Balazs Benics <[email protected]>

Author: NagyDonat

clang/lib/StaticAnalyzer/Core/MemRegion.cpp

@@ -1222,8 +1222,7 @@ MemRegionManager::getElementRegion(QualType elementType, NonLoc Idx,
   // The address space must be preserved because some target-specific address
   // spaces influence the size of the pointer value which is represented by the
   // element region.
-  LangAS AS = elementType.getAddressSpace();
-  if (AS != LangAS::Default) {
+  if (LangAS AS = elementType.getAddressSpace()) {
     Qualifiers Quals;
     Quals.setAddressSpace(AS);
     T = Ctx.getQualifiedType(T, Quals);

clang/test/Analysis/element-region-address-space.c

@@ -1,11 +1,11 @@
 // RUN: %clang_analyze_cc1 -triple amdgcn-unknown-unknown \
-// RUN: -analyzer-checker=core,unix.Malloc -verify %s
+// RUN:   -analyzer-checker=core -verify %s
 
 // expected-no-diagnostics
 //
 // By default, pointers are 64-bits.
 #define ADDRESS_SPACE_32BITS __attribute__((address_space(3)))
 
 int test(ADDRESS_SPACE_32BITS int *p, ADDRESS_SPACE_32BITS void *q) {
-  return p == q;
+  return p == q; // no-crash
 }