Skip to content

Commit 2d168ba

Browse files
fixup! Address review comments
1 parent 5acd418 commit 2d168ba

File tree

1 file changed

+12
-11
lines changed

1 file changed

+12
-11
lines changed

lldb/docs/resources/lldbgdbremote.md

Lines changed: 12 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -750,16 +750,19 @@ The reply packet starts with a comma-separated list of numbers formatted in
750750
base-16, denoting how many bytes were read from each range, in the same order
751751
as the request packet. The list is followed by a `;`, followed by a sequence of
752752
bytes containing binary encoded data for all memory that was read. The length
753-
of this sequence must be equal to the sum of the numbers provided at the start
754-
of the reply. The order of the binary data is the same as the order of the
755-
ranges in the request packet.
753+
of the binary encodeed data, after being decoded as required by the GDB remote
754+
protocol, must be equal to the sum of the numbers provided at the start of the
755+
reply. The order of the binary data is the same as the order of the ranges in
756+
the request packet.
756757
757-
If an entire range is not readable, the stub may perform a partial read of a
758-
prefix of the range.
758+
If some part of a range is not readable, the stub may perform a partial read of
759+
a prefix of the range. In other words, partial reads will only ever be from the
760+
start of the range, never the middle or end. Support for partial reads depends
761+
on the debug stub.
759762
760-
If the stub is unable to read any bytes from a particular range, it must return
761-
a length of "zero" for that range in the reply packet; no bytes for this memory
762-
range are included in the sequence of bytes that follows.
763+
If, by applying the rules above, the stub has read zero bytes from a range, it
764+
must return a length of zero for that range in the reply packet; no bytes for
765+
this memory range are included in the sequence of bytes that follows.
763766
764767
A stub that supports this packet must include `MultiMemRead+` in the reply to
765768
`qSupported`.
@@ -778,9 +781,7 @@ send packet: $MultiMemRead:ranges:100a00,0;
778781
read packet: $0;
779782
```
780783
781-
In the example above, a read of zero bytes was requested. A zero-length request
782-
provides an alternative way of testing whether the stub supports
783-
`MultiMemRead`.
784+
In the example above, a read of zero bytes was requested.
784785
785786
**Priority to Implement:** Only required for performance, the debugger will
786787
fall back to doing separate read requests if this packet is unavailable.

0 commit comments

Comments
 (0)