pr feedback typo+todo

Keenuts · Keenuts · commit 2d57fc34300d · 2024-10-29T16:47:57.000+01:00
Signed-off-by: Nathan Gauër &lt;brioche@google.com&gt;
diff --git a/llvm/test/CodeGen/SPIRV/HlslBufferLoad.ll b/llvm/test/CodeGen/SPIRV/HlslBufferLoad.ll
@@ -1,3 +1,4 @@
+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-vulkan-library %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-library %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/ShaderBufferImage.ll b/llvm/test/CodeGen/SPIRV/ShaderBufferImage.ll
@@ -1,3 +1,4 @@
+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-vulkan-library %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-library %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/ShaderImage.ll b/llvm/test/CodeGen/SPIRV/ShaderImage.ll
@@ -1,3 +1,4 @@
+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-vulkan-library %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-library %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/basic_int_types.ll b/llvm/test/CodeGen/SPIRV/basic_int_types.ll
@@ -1,3 +1,4 @@
+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/basic_int_types_spirvdis.ll b/llvm/test/CodeGen/SPIRV/basic_int_types_spirvdis.ll
@@ -1,3 +1,4 @@
+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; REQUIRES: spirv-tools
 ; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - --filetype=obj | spirv-dis | FileCheck %s
 ; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - --filetype=obj | spirv-dis | FileCheck %s
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WaveIsFirstLane.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/WaveIsFirstLane.ll
@@ -1,4 +1,3 @@
-; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/degrees.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/degrees.ll
@@ -1,3 +1,4 @@
+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/fdot.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/fdot.ll
@@ -1,4 +1,3 @@
-; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/idot.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/idot.ll
@@ -1,4 +1,3 @@
-; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/length.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/length.ll
@@ -1,4 +1,3 @@
-; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/radians.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/radians.ll
@@ -1,3 +1,4 @@
+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/saturate.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/saturate.ll
@@ -1,4 +1,3 @@
-; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/sign.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/sign.ll
@@ -1,4 +1,3 @@
-; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/literals.ll b/llvm/test/CodeGen/SPIRV/literals.ll
@@ -1,3 +1,4 @@
+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"
 ; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o - | FileCheck %s
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj | spirv-val %}
 
diff --git a/llvm/test/CodeGen/SPIRV/structurizer/loop-continue-split.ll b/llvm/test/CodeGen/SPIRV/structurizer/loop-continue-split.ll
@@ -1,7 +1,7 @@
 ; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-vulkan-compute %s -o - -filetype=obj | spirv-val %}
 ; RUN: llc -mtriple=spirv-unknown-vulkan-compute -O0 %s -o - | FileCheck %s
 
-; The goal of this test is to volontarily create 2 overlapping convergence
+; The goal of this test is to voluntarily create 2 overlapping convergence
 ; structures: the loop, and the inner condition.
 ; Here, the condition header also branches to 2 internal nodes, which are not
 ; directly a merge/exits.

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"`
`1`	`2`	`; RUN: llc -O0 -mtriple=spirv-vulkan-library %s -o - \| FileCheck %s`
`2`	`3`	`; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-library %s -o - -filetype=obj \| spirv-val %}`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"`
`1`	`2`	`; RUN: llc -verify-machineinstrs -O0 -mtriple=spirv32-unknown-unknown %s -o - \| FileCheck %s`
`2`	`3`	`; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv32-unknown-unknown %s -o - -filetype=obj \| spirv-val %}`
`3`	`4`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"`
`1`	`2`	`; REQUIRES: spirv-tools`
`2`	`3`	`; RUN: llc -O0 -mtriple=spirv32-unknown-unknown %s -o - --filetype=obj \| spirv-dis \| FileCheck %s`
`3`	`4`	`; RUN: llc -O0 -mtriple=spirv64-unknown-unknown %s -o - --filetype=obj \| spirv-dis \| FileCheck %s`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,3 @@`
`1`		`-; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"`
`2`	`1`	`; RUN: llc -O0 -mtriple=spirv-unknown-linux %s -o - \| FileCheck %s`
`3`	`2`	`; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj \| spirv-val %}`
`4`	`3`
Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,4 @@`
	`1`	`+; TODO(pull/110270): verifier, fix G_BITCAST error "bitcast must change type"`
`1`	`2`	`; RUN: llc -O0 -mtriple=spirv-unknown-unknown %s -o - \| FileCheck %s`
`2`	`3`	`; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj \| spirv-val %}`
`3`	`4`