Addressing code review comment

mahabadm · mahabadm · commit 2de3961a6982 · 2025-08-08T08:50:58.000+01:00
Signed-off-by: Mohammadreza Ameri Mahabadian &lt;mohammadreza.amerimahabadian@arm.com&gt;
diff --git a/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp b/mlir/lib/Target/SPIRV/Serialization/Serializer.cpp
@@ -958,7 +958,7 @@ Serializer::prepareDenseElementsConstant(Location loc, Type constType,
   auto elementType = cast<spirv::CompositeType>(constType).getElementType(0);
   if (auto tensorArmType = dyn_cast<spirv::TensorArmType>(constType)) {
     ArrayRef<int64_t> innerShape = tensorArmType.getShape().drop_front();
-    if (innerShape.size() > 0)
+    if (!innerShape.empty())
       elementType = spirv::TensorArmType::get(innerShape, elementType);
   }
 

Original file line number	Diff line number	Diff line change
`@@ -958,7 +958,7 @@ Serializer::prepareDenseElementsConstant(Location loc, Type constType,`
`958`	`958`	`auto elementType = cast<spirv::CompositeType>(constType).getElementType(0);`
`959`	`959`	`if (auto tensorArmType = dyn_cast<spirv::TensorArmType>(constType)) {`
`960`	`960`	`ArrayRef<int64_t> innerShape = tensorArmType.getShape().drop_front();`
`961`		`- if (innerShape.size() > 0)`
	`961`	`+ if (!innerShape.empty())`
`962`	`962`	`elementType = spirv::TensorArmType::get(innerShape, elementType);`
`963`	`963`	`}`
`964`	`964`