Add TODO.

dcaballe · dcaballe · commit 2dfe220a09f8 · 2025-01-31T14:09:27.000-08:00
diff --git a/mlir/lib/Dialect/Vector/Transforms/VectorInsertExtractStridedSliceRewritePatterns.cpp b/mlir/lib/Dialect/Vector/Transforms/VectorInsertExtractStridedSliceRewritePatterns.cpp
@@ -318,6 +318,8 @@ class DecomposeNDExtractStridedSlice
   }
 };
 
+// TODO: Make sure these `populate*` patterns are tested in isolation.
+
 void vector::populateVectorInsertExtractStridedSliceDecompositionPatterns(
     RewritePatternSet &patterns, PatternBenefit benefit) {
   patterns.add<DecomposeDifferentRankInsertStridedSlice,

Original file line number	Diff line number	Diff line change
`@@ -318,6 +318,8 @@ class DecomposeNDExtractStridedSlice`
`318`	`318`	`}`
`319`	`319`	`};`
`320`	`320`
	`321`	+// TODO: Make sure these `populate*` patterns are tested in isolation.
	`322`	`+`
`321`	`323`	`void vector::populateVectorInsertExtractStridedSliceDecompositionPatterns(`
`322`	`324`	`RewritePatternSet &patterns, PatternBenefit benefit) {`
`323`	`325`	`patterns.add<DecomposeDifferentRankInsertStridedSlice,`