fix: avoid useless string copies

Author: hulxv

clang-tools-extra/clang-doc/HTMLGenerator.cpp

@@ -518,16 +518,15 @@ writeFileDefinition(const ClangDocContext &CDCtx, const Location &L) {
       std::make_unique<TagNode>(HTMLTag::TAG_A, std::to_string(L.LineNumber));
   // The links to a specific line in the source code use the github /
   // googlesource notation so it won't work for all hosting pages.
-  std::string LineAnchor =
-      formatv("#{0}{1}", RepositoryLinePrefix, L.LineNumber);
-
-  LocNumberNode->Attributes.emplace_back("href", (FileURL + LineAnchor).str());
+  LocNumberNode->Attributes.emplace_back(
+      "href",
+      (FileURL + formatv("#{0}{1}", CDCtx.RepositoryLinePrefix.value_or(""),
+                         L.LineNumber))
+          .str());
   Node->Children.emplace_back(std::move(LocNumberNode));
   Node->Children.emplace_back(std::make_unique<TextNode>(" of file "));
-
   auto LocFileNode = std::make_unique<TagNode>(
       HTMLTag::TAG_A, llvm::sys::path::filename(FileURL));
-
   LocFileNode->Attributes.emplace_back("href", std::string(FileURL));
   Node->Children.emplace_back(std::move(LocFileNode));
   return Node;

clang-tools-extra/clang-doc/MDGenerator.cpp

@@ -59,11 +59,9 @@ static void writeFileDefinition(const ClangDocContext &CDCtx, const Location &L,
        << "*";
   } else {
 
-    std::string LineAnchor =
-        formatv("#{0}{1}", CDCtx.RepositoryLinePrefix.value_or(""),
-                std::to_string(L.LineNumber));
-
-    OS << formatv("*Defined at [{0}{1}]({0}{2})*", LineAnchor, L.Filename,
+    OS << formatv("*Defined at [#{0}{1}{2}](#{0}{1}{3})*",
+                  CDCtx.RepositoryLinePrefix.value_or(""),
+                  std::to_string(L.LineNumber), L.Filename,
                   StringRef{*CDCtx.RepositoryUrl});
   }
   OS << "\n\n";