fixup! use CreateValueObjectFromData; add test-case; remove redundant Scalar::IsValid check

Author: Michael137

lldb/source/API/SBType.cpp

@@ -709,15 +709,18 @@ lldb::SBValue SBType::GetTemplateArgumentValue(lldb::SBTarget target,
     return {};
 
   Scalar value{arg->value};
+  DataExtractor data;
+  value.GetData(data);
 
-  if (!value.IsValid())
+  ExecutionContext exe_ctx;
+  auto target_sp = target.GetSP();
+  if (!target_sp)
     return {};
 
-  DataExtractor data;
-  value.GetData(data);
+  target_sp->CalculateExecutionContext(exe_ctx);
 
-  return SBValue(ValueObjectConstResult::Create(target.GetSP().get(), arg->type,
-                                                ConstString("value"), data));
+  return ValueObject::CreateValueObjectFromData("value", data, exe_ctx,
+                                                arg->type);
 }
 
 SBType SBType::FindDirectNestedType(const char *name) {

lldb/test/API/lang/cpp/template-arguments/TestCppTemplateArguments.py

@@ -46,6 +46,10 @@ def test(self):
         self.assertEqual(template_type.GetTemplateArgumentType(2).GetName(), "")
 
         value = self.expect_expr("temp2", result_type="Foo<short, -2>")
+
+        # Can't get template parameter value with invalid target.
+        self.assertFalse(value.GetType().GetTemplateArgumentValue(lldb.SBTarget(), 1))
+
         template_param_value = value.GetType().GetTemplateArgumentValue(target, 1)
         self.assertTrue(template_param_value)
         self.assertEqual(template_param_value.GetTypeName(), "short")