Add implementaion of overloaded versions of getAttributeValue, getAttributeString in ELFAttrParserExtended that do not take StringRef

with assertion in case they are being used by mistake.

Author: sivan-shani

llvm/include/llvm/Support/ELFAttrParserExtended.h

@@ -37,8 +37,10 @@ class ELFExtendedAttrParser : public ELFAttributeParser {
 public:
   Error parse(ArrayRef<uint8_t> Section, llvm::endianness Endian) override;
 
+  std::optional<unsigned> getAttributeValue(unsigned Tag) const override;
   std::optional<unsigned> getAttributeValue(StringRef BuildAttrSubsectionName,
                                             unsigned Tag) const override;
+  std::optional<StringRef> getAttributeString(unsigned Tag) const override;
   std::optional<StringRef> getAttributeString(StringRef BuildAttrSubsectionName,
                                               unsigned Tag) const override;
 

llvm/lib/Support/ELFAttrParserExtended.cpp

@@ -21,6 +21,14 @@
 using namespace llvm;
 using namespace ELFAttrs;
 
+std::optional<unsigned>
+ELFExtendedAttrParser::getAttributeValue(unsigned Tag) const {
+  assert(
+      0 &&
+      "use getAttributeValue overloaded version accepting Stringref, unsigned");
+  return std::nullopt;
+}
+
 std::optional<unsigned>
 ELFExtendedAttrParser::getAttributeValue(StringRef BuildAttrSubsectionName,
                                          unsigned Tag) const {
@@ -34,6 +42,14 @@ ELFExtendedAttrParser::getAttributeValue(StringRef BuildAttrSubsectionName,
   return std::nullopt;
 }
 
+std::optional<StringRef>
+ELFExtendedAttrParser::getAttributeString(unsigned Tag) const {
+  assert(
+      0 &&
+      "use getAttributeValue overloaded version accepting Stringref, unsigned");
+  return std::nullopt;
+}
+
 std::optional<StringRef>
 ELFExtendedAttrParser::getAttributeString(StringRef BuildAttrSubsectionName,
                                           unsigned Tag) const {