clean more

Author: vinay-deshmukh

libcxx/include/__tree

@@ -1886,99 +1886,7 @@ pair<typename __tree<_Tp, _Compare, _Allocator>::iterator, bool>
   bool __inserted              = false;
   if (__child == nullptr) {
     __node_holder __h = __construct_node(std::forward<_Args>(__args)...);
-
-    /*
-     error: cannot convert
-     '__node_holder'
-     (aka
-    ' unique_ptr<
-        __tree_node<
-          std::__value_type<int, double>,
-          min_pointer<void, std::integral_constant<unsigned long, 0> >
-        >,
-        __tree_node_destructor<
-          min_allocator<
-            std::__tree_node<
-              std::__value_type<int, double>,
-              min_pointer<void, std::integral_constant<unsigned long, 0> >
-            >
-          >
-        >
-      >
-    '
-     )
-      to 'double' without a conversion operator
-    */
-    // double d2 =static_cast<double>(__h);
-    // (void)d2;
-
-    /*
-      error: cannot convert 'pointer'
-      (aka
-    ' min_pointer<
-        std::__tree_node<
-          std::__value_type<int, double>,
-          min_pointer<void, std::integral_constant<unsigned long, 0>>
-        >
-      >
-    ') to 'double' without a conversion operator
-     */
-    // double d =static_cast<double>(__h.get());
-    // (void)d;
-
-    /*
-    error: cannot convert '__node_base_pointer' (aka
-    ' min_pointer<
-        std::__tree_node_base<
-          min_pointer<void, std::integral_constant<unsigned long, 0>>
-        >,
-        std::integral_constant<unsigned long, 0>
-      >
-    ') to 'double' without a conversion operator
-    */
-
-    // __node_base_pointer xxx = nullptr;
-    // (void)xxx;
-    // double d3 =static_cast<double>(xxx);
-    // (void)d3;
-
-    // __node_base_pointer __foo = static_cast<__node_base_pointer>(__h.get());
-    // (void)__foo;
-    // __maybe_unused__ __node_base_pointer __foo2 = __node_base_pointer(__h.get());
-
-    /*
-    error: cannot convert '__tree<std::__value_type<int, double>, std::__map_value_compare<int, std::pair<const int,
-    double>, std::less<int>, true>, min_allocator<std::pair<const int, double>>>::__node_holder' (aka
-    'unique_ptr<__tree_node<std::__value_type<int, double>, min_pointer<void, std::integral_constant<unsigned long,
-    0>>>, __tree_node_destructor<min_allocator<std::__tree_node<std::__value_type<int, double>, min_pointer<void,
-    std::integral_constant<unsigned long, 0>>>>>>') to 'double' without a conversion operator
-    */
-    // __tree<_Tp, _Compare, _Allocator>::__node_holder __tmp_nh;
-    // double __xxx = static_cast<double>(__tmp_nh);
-
-    /*
-    error: cannot convert 'pointer' (aka 'min_pointer<std::__tree_node<std::__value_type<int, double>, min_pointer<void,
-    std::integral_constant<unsigned long, 0>>>>') to 'double' without a conversion operator
-    */
-    // __tree<_Tp, _Compare, _Allocator>::__node_holder __tmp_nh;
-    // double __xxx = static_cast<double>(__tmp_nh.get());
-
-    /*
-    note:
-    cast from 'void *' is not allowed in a constant expression
-    because the pointed object type
-      'std::__tree_node<std::__value_type<int, double>, min_pointer<void>>'
-    is not similar to the target type
-      'std::__tree_node_base<min_pointer<void>>'
-    */
-
-    // TODO: collapse into one branch
-    if (__libcpp_is_constant_evaluated()) {
-      __insert_node_at(__parent, __child, std::__static_fancy_pointer_cast<__node_base_pointer>(__h.get()));
-    } else {
-      __insert_node_at(__parent, __child, static_cast<__node_base_pointer>(__h.get()));
-    }
-
+    __insert_node_at(__parent, __child, std::__static_fancy_pointer_cast<__node_base_pointer>(__h.get()));
     __r        = __h.release();
     __inserted = true;
   }