Skip to content

Commit 328c5c9

Browse files
committed
[VectorCombine] foldSelectShuffle - remove extra adds of old shuffles to worklist
We already push the old shuffles to the worklist as part of the replaceValue calls, so we shouldn't need to add them to the deferred list as well - my guess is this was to ensure that the instructions got erased first to help cleanup unused instructions, but eraseInstruction should handle this now.
1 parent 505d35a commit 328c5c9

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

llvm/lib/Transforms/Vectorize/VectorCombine.cpp

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3036,8 +3036,6 @@ bool VectorCombine::foldSelectShuffle(Instruction &I, bool FromReduction) {
30363036
Worklist.pushValue(NSV0B);
30373037
Worklist.pushValue(NSV1A);
30383038
Worklist.pushValue(NSV1B);
3039-
for (auto *S : Shuffles)
3040-
Worklist.add(S);
30413039
return true;
30423040
}
30433041

0 commit comments

Comments
 (0)