Remove IsPCRel parameter

Information can be retrieved from `Fixup`.

Author: redstar

llvm/include/llvm/MC/MCGOFFObjectWriter.h

@@ -35,8 +35,8 @@ class MCGOFFObjectTargetWriter : public MCObjectTargetWriter {
 
   ~MCGOFFObjectTargetWriter() override = default;
 
-  virtual unsigned getRelocType(const MCValue &Target, const MCFixup &Fixup,
-                                bool IsPCRel) const = 0;
+  virtual unsigned getRelocType(const MCValue &Target,
+                                const MCFixup &Fixup) const = 0;
 
   Triple::ObjectFormatType getFormat() const override { return Triple::GOFF; }
 

llvm/lib/MC/GOFFObjectWriter.cpp

@@ -751,9 +751,8 @@ void GOFFObjectWriter::recordRelocation(const MCFragment &F,
   const uint32_t Length = FKI.TargetSize / 8;
   assert(FKI.TargetSize % 8 == 0 && "Target Size not multiple of 8");
   const uint64_t FixupOffset = Asm->getFragmentOffset(F) + Fixup.getOffset();
-  bool IsPCRel = Fixup.isPCRel();
 
-  unsigned RelocType = TargetObjectWriter->getRelocType(Target, Fixup, IsPCRel);
+  unsigned RelocType = TargetObjectWriter->getRelocType(Target, Fixup);
 
   const MCSectionGOFF *PSection = static_cast<MCSectionGOFF *>(F.getParent());
   const auto &A = *static_cast<const MCSymbolGOFF *>(Target.getAddSym());

llvm/lib/Target/SystemZ/MCTargetDesc/SystemZGOFFObjectWriter.cpp

@@ -18,19 +18,18 @@ class SystemZGOFFObjectWriter : public MCGOFFObjectTargetWriter {
 public:
   SystemZGOFFObjectWriter();
 
-  unsigned getRelocType(const MCValue &Target, const MCFixup &Fixup,
-                        bool IsPCRel) const override;
+  unsigned getRelocType(const MCValue &Target,
+                        const MCFixup &Fixup) const override;
 };
 } // end anonymous namespace
 
 SystemZGOFFObjectWriter::SystemZGOFFObjectWriter()
     : MCGOFFObjectTargetWriter() {}
 
 unsigned SystemZGOFFObjectWriter::getRelocType(const MCValue &Target,
-                                               const MCFixup &Fixup,
-                                               bool IsPCRel) const {
+                                               const MCFixup &Fixup) const {
   switch (Target.getSpecifier()) {
-  case SystemZ::S_PLT:  // TODO This doen't make sense.
+  case SystemZ::S_PLT: // TODO This doen't make sense.
     return Reloc_Type_RelImm;
   case SystemZ::S_RCon:
     return Reloc_Type_RCon;
@@ -39,7 +38,7 @@ unsigned SystemZGOFFObjectWriter::getRelocType(const MCValue &Target,
   case SystemZ::S_QCon:
     return Reloc_Type_QCon;
   case SystemZ::S_None:
-    if (IsPCRel)
+    if (Fixup.isPCRel())
       return Reloc_Type_RelImm;
     return Reloc_Type_ACon;
   }