Skip to content

Commit 33313ae

Browse files
committed
[libc++] Reduce the number of warnings when running SPEC
Using -Wall and -Wextra when building SPEC leads to extremely large log files. Since we don't actually care about warnings in these benchmarks, this patches tones down the number of warnings a bit.
1 parent 721d1a0 commit 33313ae

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

libcxx/test/benchmarks/spec.gen.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,9 @@
2828
link_flags = (test_dir / 'link_flags.subs').open().read().strip()
2929
spec_dir = pathlib.Path((test_dir / 'spec_dir.subs').open().read().strip())
3030

31+
# Remove -Wall, -Wextra and -Werror from the flags since we don't care about enabling all warnings inside SPEC
32+
compile_flags = compile_flags.replace('-Wall', '').replace('-Wextra', '').replace('-Werror', '')
33+
3134
# Setup the configuration file
3235
test_dir.mkdir(parents=True, exist_ok=True)
3336
spec_config = test_dir / 'spec-config.cfg'
@@ -46,7 +49,7 @@
4649
copies = 1
4750
threads = 1
4851
CC = cc -O3
49-
CXX = {cxx} {compile_flags} {flags} {link_flags} -Wno-error
52+
CXX = {cxx} {compile_flags} {flags} {link_flags}
5053
CC_VERSION_OPTION = --version
5154
CXX_VERSION_OPTION = --version
5255
EXTRA_PORTABILITY = -DSPEC_NO_CXX17_SPECIAL_MATH_FUNCTIONS # because libc++ doesn't implement the special math functions yet

0 commit comments

Comments
 (0)