Skip to content

Commit 33d9e3c

Browse files
committed
Enable logging in shell tests so that there is coverage of at least some
of the logging code while testing.
1 parent fc735fc commit 33d9e3c

6 files changed

+18
-0
lines changed

lldb/test/Shell/BoundsSafety/boundssafety_soft_trap_call_minimal.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
plugin list instrumentation-runtime.BoundsSafety
1111
# CHECK: [+] BoundsSafety
1212

13+
# Emit logging so that the code has test coverage
14+
log enable lldb instrumentation-runtime
15+
1316
run
1417

1518
# CHECK: * thread #{{.*}} stop reason = Soft Bounds check failed: indexing above upper bound in 'array[index]'{{$}}

lldb/test/Shell/BoundsSafety/boundssafety_soft_trap_call_minimal_missing_reason.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
plugin list instrumentation-runtime.BoundsSafety
1313
# CHECK: [+] BoundsSafety
1414

15+
# Emit logging so that the code has test coverage
16+
log enable lldb instrumentation-runtime
17+
1518
run
1619

1720
# CHECK: * thread #{{.*}} stop reason = Soft Bounds check failed{{$}}

lldb/test/Shell/BoundsSafety/boundssafety_soft_trap_call_str.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
plugin list instrumentation-runtime.BoundsSafety
1111
# CHECK: [+] BoundsSafety
1212

13+
# Emit logging so that the code has test coverage
14+
log enable lldb instrumentation-runtime
15+
1316
run
1417

1518
# CHECK: * thread #{{.*}} stop reason = Soft Bounds check failed: indexing above upper bound in 'array[index]'{{$}}

lldb/test/Shell/BoundsSafety/boundssafety_soft_trap_call_with_str_missing_reason.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
plugin list instrumentation-runtime.BoundsSafety
1313
# CHECK: [+] BoundsSafety
1414

15+
# Emit logging so that the code has test coverage
16+
log enable lldb instrumentation-runtime
17+
1518
run
1619

1720
# CHECK: * thread #{{.*}} stop reason = Soft Bounds check failed{{$}}

lldb/test/Shell/BoundsSafety/boundssafety_soft_trap_call_with_str_no_dbg_info.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@
1010
plugin list instrumentation-runtime.BoundsSafety
1111
# CHECK: [+] BoundsSafety
1212

13+
# Emit logging so that the code has test coverage
14+
log enable lldb instrumentation-runtime
15+
1316
run
1417

1518
# CHECK: * thread #{{.*}} stop reason = Soft Bounds check failed: indexing above upper bound in 'array[index]'{{$}}

lldb/test/Shell/BoundsSafety/boundssafety_soft_trap_call_with_str_no_dbg_info_null_str.test

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,9 @@
1212
plugin list instrumentation-runtime.BoundsSafety
1313
# CHECK: [+] BoundsSafety
1414

15+
# Emit logging so that the code has test coverage
16+
log enable lldb instrumentation-runtime
17+
1518
run
1619

1720
# This exists to check that the instrumentation correctly handles

0 commit comments

Comments
 (0)