fixup! Address review comment

topperc · topperc · commit 34a8bc1adf15 · 2025-06-19T19:06:29.000-07:00
diff --git a/llvm/lib/Target/RISCV/RISCVISelLowering.cpp b/llvm/lib/Target/RISCV/RISCVISelLowering.cpp
@@ -16631,12 +16631,8 @@ struct NodeExtensionHelper {
   }
 
   bool isSupportedFPExtend(MVT NarrowEltVT, const RISCVSubtarget &Subtarget) {
-    if (NarrowEltVT == MVT::f32)
-      return true;
-    // Any f16 extension will need zvfh
-    if (NarrowEltVT == MVT::f16 && Subtarget.hasVInstructionsF16())
-      return true;
-    return false;
+    return (NarrowEltVT == MVT::f32 ||
+            (NarrowEltVT == MVT::f16 && Subtarget.hasVInstructionsF16()));
   }
 
   bool isSupportedBF16Extend(MVT NarrowEltVT, const RISCVSubtarget &Subtarget) {

Original file line number	Diff line number	Diff line change
`@@ -16631,12 +16631,8 @@ struct NodeExtensionHelper {`
`16631`	`16631`	`}`
`16632`	`16632`
`16633`	`16633`	`bool isSupportedFPExtend(MVT NarrowEltVT, const RISCVSubtarget &Subtarget) {`
`16634`		`- if (NarrowEltVT == MVT::f32)`
`16635`		`- return true;`
`16636`		`- // Any f16 extension will need zvfh`
`16637`		`- if (NarrowEltVT == MVT::f16 && Subtarget.hasVInstructionsF16())`
`16638`		`- return true;`
`16639`		`- return false;`
	`16634`	`+ return (NarrowEltVT == MVT::f32 \|\|`
	`16635`	`+ (NarrowEltVT == MVT::f16 && Subtarget.hasVInstructionsF16()));`
`16640`	`16636`	`}`
`16641`	`16637`
`16642`	`16638`	`bool isSupportedBF16Extend(MVT NarrowEltVT, const RISCVSubtarget &Subtarget) {`