Check if dyncast was succesful

Author: Felix Kellenbenz

llvm/lib/Transforms/InstCombine/InstCombineMulDivRem.cpp

@@ -1897,41 +1897,46 @@ Instruction *InstCombinerImpl::visitFDiv(BinaryOperator &I) {
     CallBase *Op1AsCallBase = dyn_cast<CallBase>(Op1);
     LibFunc Op0LibFunc, Op1LibFunc;
 
-    TLI.getLibFunc(*Op1AsCallBase, Op1LibFunc);
-    TLI.getLibFunc(*Op0AsCallBase, Op0LibFunc);
+    if (Op1AsCallBase && Op0AsCallBase) {
+      TLI.getLibFunc(*Op1AsCallBase, Op1LibFunc);
+      TLI.getLibFunc(*Op0AsCallBase, Op0LibFunc);
 
-    bool ArgsMatch = match(Op0AsCallBase->getArgOperand(0), m_Value(Y)) &&
-                     match(Op1AsCallBase->getArgOperand(0), m_Specific(Y));
+      bool ArgsMatch = match(Op0AsCallBase->getArgOperand(0), m_Value(Y)) &&
+                       match(Op1AsCallBase->getArgOperand(0), m_Specific(Y));
 
-    bool IsTanH =
-        ArgsMatch &&
-        ((Op0LibFunc == LibFunc_sinh && Op1LibFunc == LibFunc_cosh) ||
-         (Op0LibFunc == LibFunc_sinhf && Op1LibFunc == LibFunc_coshf) ||
-         (Op0LibFunc == LibFunc_sinhl && Op1LibFunc == LibFunc_coshl));
+      bool IsTanH =
+          ArgsMatch &&
+          ((Op0LibFunc == LibFunc_sinh && Op1LibFunc == LibFunc_cosh) ||
+           (Op0LibFunc == LibFunc_sinhf && Op1LibFunc == LibFunc_coshf) ||
+           (Op0LibFunc == LibFunc_sinhl && Op1LibFunc == LibFunc_coshl));
 
-    bool IsCotH =
-        !IsTanH && ArgsMatch &&
-        ((Op1LibFunc == LibFunc_sinh && Op0LibFunc == LibFunc_cosh) ||
-         (Op1LibFunc == LibFunc_sinhf && Op0LibFunc == LibFunc_coshf) ||
-         (Op1LibFunc == LibFunc_sinhl && Op0LibFunc == LibFunc_coshl));
+      bool IsCotH =
+          !IsTanH && ArgsMatch &&
+          ((Op1LibFunc == LibFunc_sinh && Op0LibFunc == LibFunc_cosh) ||
+           (Op1LibFunc == LibFunc_sinhf && Op0LibFunc == LibFunc_coshf) ||
+           (Op1LibFunc == LibFunc_sinhl && Op0LibFunc == LibFunc_coshl));
 
-    if ((IsTanH || IsCotH) && hasFloatFn(M, &TLI, I.getType(), LibFunc_tanh,
-                                         LibFunc_tanhf, LibFunc_tanhl)) {
+      if ((IsTanH || IsCotH) && hasFloatFn(M, &TLI, I.getType(), LibFunc_tanh,
+                                           LibFunc_tanhf, LibFunc_tanhl)) {
 
-      Value *Res =
-          GetReplacement(Y, IsCotH, LibFunc_tanh, LibFunc_tanhf, LibFunc_tanhl);
+        Value *Res = GetReplacement(Y, IsCotH, LibFunc_tanh, LibFunc_tanhf,
+                                    LibFunc_tanhl);
+
+        Instruction *Replacement = replaceInstUsesWith(I, Res);
 
-      Instruction *Replacement = replaceInstUsesWith(I, Res);
+        if (!Op0AsCallBase->use_empty())
+          Op0AsCallBase->replaceAllUsesWith(
+              PoisonValue::get(Op0AsCallBase->getType()));
 
-      Op0AsCallBase->replaceAllUsesWith(
-          PoisonValue::get(Op0AsCallBase->getType()));
-      Op1AsCallBase->replaceAllUsesWith(
-          PoisonValue::get(Op1AsCallBase->getType()));
+        if (!Op1AsCallBase->use_empty())
+          Op1AsCallBase->replaceAllUsesWith(
+              PoisonValue::get(Op1AsCallBase->getType()));
 
-      Op0AsCallBase->eraseFromParent();
-      Op1AsCallBase->eraseFromParent();
+        Op0AsCallBase->eraseFromParent();
+        Op1AsCallBase->eraseFromParent();
 
-      return Replacement;
+        return Replacement;
+      }
     }
   }
 

llvm/test/Transforms/InstCombine/fdiv-cosh-sinh.ll

@@ -35,8 +35,8 @@ define double @fdiv_reassoc_cosh_strict_sinh_strict(double %a, ptr dereferenceab
 ;
   %cosh = call double @cosh(double %a)
   %sinh = call double @sinh(double %a)
-  %div = fdiv reassoc double %1, %2
-  ret double %div %cosh, %sinh
+  %div = fdiv reassoc double %cosh, %sinh
+  ret double %div
 }
 
 define double @fdiv_reassoc_cosh_reassoc_sinh_strict(double %a) {

llvm/test/Transforms/InstCombine/fdiv-sinh-cosh.ll

@@ -47,7 +47,7 @@ define double @fdiv_sin_cos_reassoc_multiple_uses_sinh(double %a) {
   %sinh = call reassoc double @sinh(double %a)
   %cosh = call reassoc double @cosh(double %a)
   %div = fdiv reassoc double %sinh, %cosh
-  call void @use(double %cosh)
+  call void @use(double %sinh)
   ret double %div
 }
 
@@ -62,7 +62,7 @@ define double @fdiv_sin_cos_reassoc_multiple_uses_cosh(double %a) {
   %sinh = call reassoc double @sinh(double %a)
   %cosh = call reassoc double @cosh(double %a)
   %div = fdiv reassoc double %sinh, %cosh
-  call void @use(double %2)
+  call void @use(double %cosh)
   ret double %div
 }