Skip to content

Commit 356a811

Browse files
authored
[PredicateInfo] Drop redundant PredicateInfo annotation (#165434)
See #165419 (comment) for details. The extra annotation `"; Has predicate info"` does not provide any extra information and might poison the UTC-generated checks introduced by #165419.
1 parent ce7cca1 commit 356a811

File tree

2 files changed

+1
-4
lines changed

2 files changed

+1
-4
lines changed

llvm/lib/Transforms/Utils/PredicateInfo.cpp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -809,7 +809,6 @@ class PredicateInfoAnnotatedWriter : public AssemblyAnnotationWriter {
809809
void emitInstructionAnnot(const Instruction *I,
810810
formatted_raw_ostream &OS) override {
811811
if (const auto *PI = PredInfo->getPredicateInfoFor(I)) {
812-
OS << "; Has predicate info\n";
813812
if (const auto *PB = dyn_cast<PredicateBranch>(PI)) {
814813
OS << "; branch predicate info { TrueEdge: " << PB->TrueEdge
815814
<< " Comparison:" << *PB->Condition << " Edge: [";

llvm/test/Transforms/Util/PredicateInfo/unnamed-types.ll

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,13 +6,11 @@
66
; Check we can use ssa.copy with unnamed types.
77

88
; CHECK-LABEL: bb:
9-
; CHECK: Has predicate info
109
; CHECK: branch predicate info { TrueEdge: 1 Comparison: %cmp1 = icmp ne ptr %arg, null Edge: [label %bb,label %bb1], RenamedOp: %arg }
1110
; CHECK-NEXT: %arg.0 = bitcast ptr %arg to ptr
1211

1312
; CHECK-LABEL: bb1:
14-
; CHECK: Has predicate info
15-
; CHECK-NEXT: branch predicate info { TrueEdge: 0 Comparison: %cmp2 = icmp ne ptr null, %tmp Edge: [label %bb1,label %bb3], RenamedOp: %tmp }
13+
; CHECK: branch predicate info { TrueEdge: 0 Comparison: %cmp2 = icmp ne ptr null, %tmp Edge: [label %bb1,label %bb3], RenamedOp: %tmp }
1614
; CHECK-NEXT: %tmp.0 = bitcast ptr %tmp to ptr
1715

1816
define void @f0(ptr %arg, ptr %tmp) {

0 commit comments

Comments
 (0)