- Added positive path for clock_settime test

- Fixed error in clock_settime struct setup
- Upd the time.rst doc with up to date info

Author: amemov

libc/docs/headers/time.rst

@@ -67,7 +67,7 @@ Implementation Status
 +---------------------+---------+---------+---------+-----------------+---------+---------+---------+---------+---------+---------+---------+---------+---------+
 | clock_getres        |         |         |         |                 |         |         |         |         |         |         |         |         |         |
 +---------------------+---------+---------+---------+-----------------+---------+---------+---------+---------+---------+---------+---------+---------+---------+
-| clock_gettime       | |check| | |check| |         |     |check|     |         |         |         |         |         |         |         |         |         |
+| clock_gettime       | |check| | |check| |         |     |check|     |         |         |         |         |         |         |         | |check| | |check| |
 +---------------------+---------+---------+---------+-----------------+---------+---------+---------+---------+---------+---------+---------+---------+---------+
 | clock_nanosleep     |         |         |         |                 |         |         |         |         |         |         |         |         |         |
 +---------------------+---------+---------+---------+-----------------+---------+---------+---------+---------+---------+---------+---------+---------+---------+

libc/src/__support/time/linux/clock_settime.cpp

@@ -34,13 +34,13 @@ ErrorOr<int> clock_settime(clockid_t clockid, const timespec *ts) {
 
   __kernel_timespec ts64{};
 
+  // Populate the 64-bit kernel structure from the user-provided timespec
+  ts64.tv_sec = static_cast<decltype(ts64.tv_sec)>(ts->tv_sec);
+  ts64.tv_nsec = static_cast<decltype(ts64.tv_nsec)>(ts->tv_nsec);
+
   ret = LIBC_NAMESPACE::syscall_impl<int>(SYS_clock_settime64,
                                           static_cast<long>(clockid),
                                           reinterpret_cast<long>(&ts64));
-  if (ret == 0) {
-    ts->tv_sec = static_cast<decltype(ts->tv_sec)>(ts64.tv_sec);
-    ts->tv_nsec = static_cast<decltype(ts->tv_nsec)>(ts64.tv_nsec);
-  }
 #else
 #error "SYS_clock_settime and SYS_clock_settime64 syscalls not available."
 #endif

libc/test/src/time/clock_settime_test.cpp

@@ -29,3 +29,26 @@ TEST_F(LlvmLibcClockSetTime, InvalidClockId) {
   ASSERT_EQ(result, -1);
   ASSERT_ERRNO_EQ(EINVAL);
 }
+
+TEST_F(LlvmLibcClockSetTime, InvalidTimespecNsec) {
+  timespec ts = {0, 1000000000L};
+  int result = LIBC_NAMESPACE::clock_settime(CLOCK_REALTIME, &ts);
+  ASSERT_EQ(result, -1);
+  ASSERT_ERRNO_EQ(EINVAL);
+}
+
+TEST_F(LlvmLibcClockSetTime, NullPointerIsEFAULT) {
+  int result = LIBC_NAMESPACE::clock_settime(CLOCK_REALTIME, nullptr);
+  ASSERT_EQ(result, -1);
+  ASSERT_ERRNO_EQ(EFAULT);
+}
+
+TEST_F(LlvmLibcClockSetTime, ClockIsSet) {
+  timespec ts = {0, 0};
+  int result = LIBC_NAMESPACE::clock_settime(CLOCK_REALTIME, &ts);
+  if (result == 0) {
+    ASSERT_ERRNO_SUCCESS();
+  } else {
+    ASSERT_ERRNO_EQ(EPERM);
+  }
+}