Skip to content

Commit 36d7e91

Browse files
[MLIR] Drop use of REQUIRES:shell from tests (#168989)
This patch drops two instances of REQUIRES: shell from MLIR tests. This feature does not mean much given the internal shell is the default for MLIR. It does prevent these tests from running on Windows, but it does not seem like there is anything inherent to these tests preventing them from running on Windows (minus maybe the lack of spirv-tools, which is explicitly required anyways.
1 parent dbac917 commit 36d7e91

File tree

2 files changed

+0
-2
lines changed

2 files changed

+0
-2
lines changed

mlir/test/Target/SPIRV/mlir-translate.mlir

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
// Check that `--spirv-save-validation-files-with-prefix` generates
22
// a correct number of files.
33

4-
// REQUIRES: shell
54
// RUN: rm -rf %t
65
// RUN: mkdir %t && mlir-translate --serialize-spirv --no-implicit-module \
76
// RUN: --split-input-file --spirv-save-validation-files-with-prefix=%t/foo %s \

mlir/test/Target/SPIRV/module.mlir

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
// RUN: mlir-translate --no-implicit-module --test-spirv-roundtrip --split-input-file %s | FileCheck %s
22

3-
// REQUIRES: shell
43
// RUN: %if spirv-tools %{ rm -rf %t %}
54
// RUN: %if spirv-tools %{ mkdir %t %}
65
// RUN: %if spirv-tools %{ mlir-translate --no-implicit-module --serialize-spirv --split-input-file --spirv-save-validation-files-with-prefix=%t/module %s %}

0 commit comments

Comments
 (0)