Skip to content

Commit 36f3dc1

Browse files
committed
fixup! Use benchmark phase instead of command line flag to select dry-run-measurement
1 parent a540385 commit 36f3dc1

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

llvm/tools/llvm-exegesis/lib/Target.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ ExegesisTarget::createBenchmarkRunner(
9898
return nullptr;
9999
case Benchmark::Latency:
100100
case Benchmark::InverseThroughput:
101-
if (BenchmarkPhaseSelector == BenchmarkPhaseSelectorE::Measure &&
101+
if (BenchmarkPhaseSelector >= BenchmarkPhaseSelectorE::Measure &&
102102
!PfmCounters.CycleCounter) {
103103
const char *ModeName = Mode == Benchmark::Latency
104104
? "latency"
@@ -116,7 +116,7 @@ ExegesisTarget::createBenchmarkRunner(
116116
State, Mode, BenchmarkPhaseSelector, ResultAggMode, ExecutionMode,
117117
ValidationCounters, BenchmarkRepeatCount);
118118
case Benchmark::Uops:
119-
if (BenchmarkPhaseSelector == BenchmarkPhaseSelectorE::Measure &&
119+
if (BenchmarkPhaseSelector >= BenchmarkPhaseSelectorE::Measure &&
120120
!PfmCounters.UopsCounter && !PfmCounters.IssueCounters)
121121
return make_error<Failure>(
122122
"can't run 'uops' mode, sched model does not define uops or issue "

llvm/tools/llvm-exegesis/llvm-exegesis.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -479,7 +479,7 @@ static void runBenchmarkConfigurations(
479479
}
480480

481481
void benchmarkMain() {
482-
if (BenchmarkPhaseSelector == BenchmarkPhaseSelectorE::Measure &&
482+
if (BenchmarkPhaseSelector >= BenchmarkPhaseSelectorE::Measure &&
483483
!UseDummyPerfCounters) {
484484
#ifndef HAVE_LIBPFM
485485
ExitWithError(
@@ -504,7 +504,7 @@ void benchmarkMain() {
504504

505505
// Preliminary check to ensure features needed for requested
506506
// benchmark mode are present on target CPU and/or OS.
507-
if (BenchmarkPhaseSelector == BenchmarkPhaseSelectorE::Measure)
507+
if (BenchmarkPhaseSelector >= BenchmarkPhaseSelectorE::Measure)
508508
ExitOnErr(State.getExegesisTarget().checkFeatureSupport());
509509

510510
if (ExecutionMode == BenchmarkRunner::ExecutionModeE::SubProcess &&

0 commit comments

Comments
 (0)