[SPIRV] Fix sanitizer-x86_64-linux-android/8085

s-perron · s-perron · commit 3752539b04a6 · 2025-04-10T10:34:50.000-04:00
The build failed because the cases covered all possibilities, so the default was not needed. I have removed the default case, and placed the llvm_unreachable after the switch. https://lab.llvm.org/buildbot/#/builders/186/builds/8085
diff --git a/llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp b/llvm/lib/Target/SPIRV/SPIRVGlobalRegistry.cpp
@@ -82,10 +82,9 @@ storageClassRequiresExplictLayout(SPIRV::StorageClass::StorageClass SC) {
   case SPIRV::StorageClass::DeviceOnlyINTEL:
   case SPIRV::StorageClass::HostOnlyINTEL:
     return false;
-  default:
-    llvm_unreachable("Unknown storage class");
-    return false;
   }
+  llvm_unreachable("Unknown storage class");
+  return false;
 }
 
 SPIRVGlobalRegistry::SPIRVGlobalRegistry(unsigned PointerSize)

Original file line number	Diff line number	Diff line change
`@@ -82,10 +82,9 @@ storageClassRequiresExplictLayout(SPIRV::StorageClass::StorageClass SC) {`
`82`	`82`	`case SPIRV::StorageClass::DeviceOnlyINTEL:`
`83`	`83`	`case SPIRV::StorageClass::HostOnlyINTEL:`
`84`	`84`	`return false;`
`85`		`- default:`
`86`		`- llvm_unreachable("Unknown storage class");`
`87`		`- return false;`
`88`	`85`	`}`
	`86`	`+ llvm_unreachable("Unknown storage class");`
	`87`	`+ return false;`
`89`	`88`	`}`
`90`	`89`
`91`	`90`	`SPIRVGlobalRegistry::SPIRVGlobalRegistry(unsigned PointerSize)`