Skip to content

Commit 3789784

Browse files
committed
Update comment
1 parent b811065 commit 3789784

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

clang-tools-extra/clang-tidy/llvm/UseNewMLIROpBuilderCheck.cpp

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -123,11 +123,10 @@ RewriteRuleWith<std::string> useNewMlirOpBuilderCheckRule() {
123123
callee(cxxMethodDecl(hasName("create"))))
124124
.bind("call");
125125
return applyFirst(
126-
{// Attempt to rewrite with a concrete builder.
127-
makeRule(cxxMemberCallExpr(unless(on(cxxTemporaryObjectExpr())), base),
126+
// Attempt rewrite given an lvalue builder, else just warn.
127+
{makeRule(cxxMemberCallExpr(unless(on(cxxTemporaryObjectExpr())), base),
128128
rewrite(node("call"), node("builder"), callArgs("call")),
129129
message),
130-
// Warn on calls on temporary objects only.
131130
makeRule(base, noopEdit(node("call")), message)});
132131
}
133132
} // namespace

0 commit comments

Comments
 (0)