We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
There was an error while loading. Please reload this page.
1 parent b811065 commit 3789784Copy full SHA for 3789784
clang-tools-extra/clang-tidy/llvm/UseNewMLIROpBuilderCheck.cpp
@@ -123,11 +123,10 @@ RewriteRuleWith<std::string> useNewMlirOpBuilderCheckRule() {
123
callee(cxxMethodDecl(hasName("create"))))
124
.bind("call");
125
return applyFirst(
126
- {// Attempt to rewrite with a concrete builder.
127
- makeRule(cxxMemberCallExpr(unless(on(cxxTemporaryObjectExpr())), base),
+ // Attempt rewrite given an lvalue builder, else just warn.
+ {makeRule(cxxMemberCallExpr(unless(on(cxxTemporaryObjectExpr())), base),
128
rewrite(node("call"), node("builder"), callArgs("call")),
129
message),
130
- // Warn on calls on temporary objects only.
131
makeRule(base, noopEdit(node("call")), message)});
132
}
133
} // namespace
0 commit comments