Skip to content

Commit 37a3aec

Browse files
sivan-shanisivan-shani
committed
change test files comments to follow lld convention
1 parent 8b1e002 commit 37a3aec

File tree

3 files changed

+40
-40
lines changed

3 files changed

+40
-40
lines changed

‎lld/test/ELF/aarch64-build-attributes-be.s‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
/// llvm-mc should not appear in the output of lld, because
88
/// AArch64 build attributes are being transformed into .gnu.properties.
99

10-
// Test mc -> big endian, lld -> little endian
10+
/// Test mc -> big endian, lld -> little endian
1111
// RUN: llvm-mc -triple=aarch64_be %s -filetype=obj -o %t.o
1212
// RUN: ld.lld %t.o --shared -o %t.so
1313
// RUN: llvm-readelf -n %t.so | FileCheck %s --check-prefix=NOTE
@@ -16,7 +16,7 @@
1616
// RUN: ld.lld -r %t.o -o %t2.o
1717
// RUN: llvm-readelf -n %t.so | FileCheck %s --check-prefix=NOTE
1818

19-
// Test mc -> little endian, lld -> big endian
19+
/// Test mc -> little endian, lld -> big endian
2020
// RUN: llvm-mc -triple=aarch64 %s -filetype=obj -o %t.o
2121
// RUN: ld.lld --EB %t.o --shared -o %t.so
2222
// RUN: llvm-readelf -n %t.so | FileCheck %s --check-prefix=NOTE
@@ -25,7 +25,7 @@
2525
// RUN: ld.lld --EB -r %t.o -o %t2.o
2626
// RUN: llvm-readelf -n %t.so | FileCheck %s --check-prefix=NOTE
2727

28-
// Test mc -> big endian, lld -> big endian
28+
/// Test mc -> big endian, lld -> big endian
2929
// RUN: llvm-mc -triple=aarch64_be %s -filetype=obj -o %t.o
3030
// RUN: ld.lld --EB %t.o --shared -o %t.so
3131
// RUN: llvm-readelf -n %t.so | FileCheck %s --check-prefix=NOTE

‎lld/test/ELF/aarch64-build-attributes-mixed.s‎

Lines changed: 19 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
1-
# RUN: rm -rf %t && split-file %s %t && cd %t
1+
// RUN: rm -rf %t && split-file %s %t && cd %t
22

3-
# RUN: llvm-mc -triple=aarch64 -filetype=obj %s -o %t11.o
4-
# RUN: llvm-mc -triple=aarch64 -filetype=obj merged-mixed-2.s -o %t12.o
5-
# RUN: llvm-mc -triple=aarch64 -filetype=obj merged-mixed-3.s -o %t13.o
6-
# RUN: ld.lld -r %t11.o %t12.o %t13.o -o %t.merged1.o
7-
# RUN: llvm-readelf -n %t.merged1.o | FileCheck %s --check-prefix=NOTE-MIXED
3+
// RUN: llvm-mc -triple=aarch64 -filetype=obj %s -o %t11.o
4+
// RUN: llvm-mc -triple=aarch64 -filetype=obj merged-mixed-2.s -o %t12.o
5+
// RUN: llvm-mc -triple=aarch64 -filetype=obj merged-mixed-3.s -o %t13.o
6+
// RUN: ld.lld -r %t11.o %t12.o %t13.o -o %t.merged1.o
7+
// RUN: llvm-readelf -n %t.merged1.o | FileCheck %s --check-prefix=NOTE-MIXED
88

9-
# NOTE-MIXED: Displaying notes found in: .note.gnu.property
10-
# NOTE-MIXED-NEXT: Owner Data size Description
11-
# NOTE-MIXED-NEXT: GNU 0x00000028 NT_GNU_PROPERTY_TYPE_0 (property note)
12-
# NOTE-MIXED-NEXT: Properties: aarch64 feature: BTI, PAC
13-
# NOTE-MIXED-NEXT: AArch64 PAuth ABI core info: platform 0x31 (unknown), version 0x13
9+
// NOTE-MIXED: Displaying notes found in: .note.gnu.property
10+
// NOTE-MIXED-NEXT: Owner Data size Description
11+
// NOTE-MIXED-NEXT: GNU 0x00000028 NT_GNU_PROPERTY_TYPE_0 (property note)
12+
// NOTE-MIXED-NEXT: Properties: aarch64 feature: BTI, PAC
13+
// NOTE-MIXED-NEXT: AArch64 PAuth ABI core info: platform 0x31 (unknown), version 0x13
1414

15-
# The Build attributes section appearing in the output of
16-
# llvm-mc should not appear in the output of lld, because
17-
# AArch64 build attributes are being transformed into .gnu.properties.
15+
/// The Build attributes section appearing in the output of
16+
/// llvm-mc should not appear in the output of lld, because
17+
/// AArch64 build attributes are being transformed into .gnu.properties.
1818

19-
# CHECK: .note.gnu.property
20-
# CHECK-NOT: .ARM.attributes
19+
// CHECK: .note.gnu.property
20+
// CHECK-NOT: .ARM.attributes
2121

2222
.aeabi_subsection aeabi_pauthabi, required, uleb128
2323
.aeabi_attribute Tag_PAuth_Platform, 49
@@ -28,7 +28,7 @@
2828
.aeabi_attribute Tag_Feature_GCS, 1
2929

3030

31-
#--- merged-mixed-2.s
31+
//--- merged-mixed-2.s
3232
.section ".note.gnu.property", "a"
3333
.long 4 // Name length is always 4 ("GNU")
3434
.long end - begin // Data length
@@ -40,15 +40,15 @@ begin:
4040
.long 4
4141
.long 7 // GNU_PROPERTY_AARCH64_FEATURE_1_BTI, PAC and GCS
4242
.long 0
43-
# PAuth ABI property note
43+
// PAuth ABI property note
4444
.long 0xc0000001 // Type: GNU_PROPERTY_AARCH64_FEATURE_PAUTH
4545
.long 16 // Data size
4646
.quad 49 // PAuth ABI platform
4747
.quad 19 // PAuth ABI version
4848
.p2align 3 // Align to 8 byte for 64 bit
4949
end:
5050

51-
#--- merged-mixed-3.s
51+
//--- merged-mixed-3.s
5252
.section .note.gnu.property, "a"
5353
.align 4
5454
.long 4 // namesz

‎lld/test/ELF/aarch64-build-attributes.s‎

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
1-
# RUN: rm -rf %t && split-file %s %t && cd %t
1+
// RUN: rm -rf %t && split-file %s %t && cd %t
22

3-
# RUN: llvm-mc -triple=aarch64 -filetype=obj %s -o %t1.o
4-
# RUN: llvm-mc -triple=aarch64 -filetype=obj merged-2.s -o %t2.o
5-
# RUN: llvm-mc -triple=aarch64 -filetype=obj merged-3.s -o %t3.o
6-
# RUN: ld.lld -r %t1.o %t2.o %t3.o -o %t.merged.o
7-
# RUN: llvm-readelf -n %t.merged.o | FileCheck %s --check-prefix=NOTE
3+
// RUN: llvm-mc -triple=aarch64 -filetype=obj %s -o %t1.o
4+
// RUN: llvm-mc -triple=aarch64 -filetype=obj merged-2.s -o %t2.o
5+
// RUN: llvm-mc -triple=aarch64 -filetype=obj merged-3.s -o %t3.o
6+
// RUN: ld.lld -r %t1.o %t2.o %t3.o -o %t.merged.o
7+
// RUN: llvm-readelf -n %t.merged.o | FileCheck %s --check-prefix=NOTE
88

9-
# NOTE: Displaying notes found in: .note.gnu.property
10-
# NOTE-NEXT: Owner Data size Description
11-
# NOTE-NEXT: GNU 0x00000028 NT_GNU_PROPERTY_TYPE_0 (property note)
12-
# NOTE-NEXT: Properties: aarch64 feature: BTI
13-
# NOTE-NEXT: AArch64 PAuth ABI core info: platform 0x31 (unknown), version 0x13
9+
// NOTE: Displaying notes found in: .note.gnu.property
10+
// NOTE-NEXT: Owner Data size Description
11+
// NOTE-NEXT: GNU 0x00000028 NT_GNU_PROPERTY_TYPE_0 (property note)
12+
// NOTE-NEXT: Properties: aarch64 feature: BTI
13+
// NOTE-NEXT: AArch64 PAuth ABI core info: platform 0x31 (unknown), version 0x13
1414

15-
# The Build attributes section appearing in the output of
16-
# llvm-mc should not appear in the output of lld, because
17-
# AArch64 build attributes are being transformed into .gnu.properties.
15+
/// The Build attributes section appearing in the output of
16+
/// llvm-mc should not appear in the output of lld, because
17+
/// AArch64 build attributes are being transformed into .gnu.properties.
1818

19-
# CHECK: .note.gnu.property
20-
# CHECK-NOT: .ARM.attributes
19+
// CHECK: .note.gnu.property
20+
// CHECK-NOT: .ARM.attributes
2121

2222
.aeabi_subsection aeabi_pauthabi, required, uleb128
2323
.aeabi_attribute Tag_PAuth_Platform, 49
@@ -28,7 +28,7 @@
2828
.aeabi_attribute Tag_Feature_GCS, 1
2929

3030

31-
#--- merged-2.s
31+
//--- merged-2.s
3232
.aeabi_subsection aeabi_pauthabi, required, uleb128
3333
.aeabi_attribute Tag_PAuth_Platform, 49
3434
.aeabi_attribute Tag_PAuth_Schema, 19
@@ -38,7 +38,7 @@
3838
.aeabi_attribute Tag_Feature_GCS, 1
3939

4040

41-
#--- merged-3.s
41+
//--- merged-3.s
4242
.aeabi_subsection aeabi_pauthabi, required, uleb128
4343
.aeabi_attribute Tag_PAuth_Platform, 49
4444
.aeabi_attribute Tag_PAuth_Schema, 19

0 commit comments

Comments
 (0)